Feat: Added Available Condition to apply_controller (#97)

* Added Available Condition * Added Available Condition * comment fix Co-authored-by: Youn Jae Kim <[email protected]>
Azure · Aug 2, 2022 · 6ec7e3f · 6ec7e3f
1 parent aae628a
commit 6ec7e3f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/pkg/controllers/apply_controller.go b/pkg/controllers/apply_controller.go
@@ -101,6 +101,7 @@ func (r *ApplyWorkReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	appliedWork := &workv1alpha1.AppliedWork{}
 	if err := r.spokeClient.Get(ctx, types.NamespacedName{Name: kLogObjRef.Name}, appliedWork); err != nil {
 		klog.ErrorS(err, utils.MessageResourceRetrieveFailed, "AppliedWork", kLogObjRef.Name)
+		meta.SetStatusCondition(&work.Status.Conditions, generateWorkAvailableStatusCondition(metav1.ConditionFalse, work.Generation))
 
 		return ctrl.Result{}, errors.Wrap(err, fmt.Sprintf(utils.MessageResourceRetrieveFailed+", %s=%s", "AppliedWork", work.Name))
 	}
@@ -138,10 +139,12 @@ func (r *ApplyWorkReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 
 	work.Status.ManifestConditions = manifestConditions
 
-	// Update status condition of work
 	workCond := generateWorkAppliedStatusCondition(manifestConditions, work.Generation)
 	work.Status.Conditions = []metav1.Condition{workCond}
 
+	//Update available status condition of work
+	meta.SetStatusCondition(&work.Status.Conditions, generateWorkAvailableStatusCondition(workCond.Status, work.Generation))
+
 	err = r.client.Status().Update(ctx, work, &client.UpdateOptions{})
 	if err != nil {
 		klog.ErrorS(err, utils.MessageResourceStatusUpdateFailed, work.Kind, kLogObjRef)
@@ -473,3 +476,25 @@ func generateWorkAppliedStatusCondition(manifestConditions []workv1alpha1.Manife
 		ObservedGeneration: observedGeneration,
 	}
 }
+
+func generateWorkAvailableStatusCondition(status metav1.ConditionStatus, observedGeneration int64) metav1.Condition {
+	if status == metav1.ConditionTrue {
+		return metav1.Condition{
+			Type:               ConditionTypeAvailable,
+			Status:             metav1.ConditionTrue,
+			LastTransitionTime: metav1.Now(),
+			Reason:             "AppliedWorkAvailable",
+			Message:            "This workload is available",
+			ObservedGeneration: observedGeneration,
+		}
+	}
+
+	return metav1.Condition{
+		Type:               ConditionTypeAvailable,
+		Status:             metav1.ConditionFalse,
+		LastTransitionTime: metav1.Now(),
+		Reason:             "AppliedWorkFailed",
+		Message:            "This workload is not fully available",
+		ObservedGeneration: observedGeneration,
+	}
+}
diff --git a/pkg/controllers/manager.go b/pkg/controllers/manager.go
@@ -33,7 +33,8 @@ const (
 	workFinalizer      = "multicluster.x-k8s.io/work-cleanup"
 	specHashAnnotation = "multicluster.x-k8s.io/spec-hash"
 
-	ConditionTypeApplied = "Applied"
+	ConditionTypeApplied   = "Applied"
+	ConditionTypeAvailable = "Available"
 
 	// number of concurrent reconcile loop for work
 	maxWorkConcurrency = 5