Fix: Adding 5 min to the reconciliation loop for apply_controller.go (#98)

* Adding 5 min to the reconciliation loop for apply_controller.go

* edited unit test

* edited unit test

Co-authored-by: Youn Jae Kim <[email protected]>

Author: aagusuab

pkg/controllers/apply_controller.go

@@ -21,6 +21,7 @@ import (
 	"crypto/sha256"
 	"encoding/json"
 	"fmt"
+	"time"
 
 	"github.com/pkg/errors"
 	v1 "k8s.io/api/core/v1"
@@ -166,7 +167,7 @@ func (r *ApplyWorkReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 		utils.EventReasonReconcileComplete,
 		utils.MessageManifestApplyComplete)
 
-	return ctrl.Result{}, nil
+	return ctrl.Result{RequeueAfter: time.Minute * 5}, nil
 }
 
 // applyManifests processes a given set of Manifests by: setting ownership, validating the manifest, and passing it on for application to the cluster.

pkg/controllers/apply_controller_unit_test.go

@@ -466,6 +466,7 @@ func TestReconcile(t *testing.T) {
 		reconciler ApplyWorkReconciler
 		req        ctrl.Request
 		wantErr    error
+		requeue    bool
 	}{
 		"work cannot be retrieved, client failed due to client error": {
 			reconciler: ApplyWorkReconciler{
@@ -618,6 +619,7 @@ func TestReconcile(t *testing.T) {
 			},
 			req:     req,
 			wantErr: nil,
+			requeue: true,
 		},
 	}
 	for testName, testCase := range testCases {
@@ -626,6 +628,9 @@ func TestReconcile(t *testing.T) {
 			if testCase.wantErr != nil {
 				assert.Containsf(t, err.Error(), testCase.wantErr.Error(), "incorrect error for Testcase %s", testName)
 			} else {
+				if testCase.requeue {
+					assert.Equal(t, ctrl.Result{RequeueAfter: time.Minute * 5}, ctrlResult, "incorrect ctrlResult for Testcase %s", testName)
+				}
 				assert.Equalf(t, false, ctrlResult.Requeue, "incorrect ctrlResult for Testcase %s", testName)
 			}
 		})