Skip to content

fix: add pydantic dependency for aks-agent #9165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add pydantic dependency for aks-agent #9165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@

/src/aks-preview/ @andyzhangx @andyliuliming @fumingzhang

/src/aks-agent/ @nilo19 @mainerd

/src/bastion/ @aavalang

/src/vm-repair/ @haagha
Expand Down
2 changes: 2 additions & 0 deletions src/aks-agent/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
poetry.lock
pyproject.toml
5 changes: 5 additions & 0 deletions src/aks-agent/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Pending
1.0.0b2
+++++++

* Add pydantic-core dependency.

1.0.0b2
+++++++

- Add MCP integration for `az aks agent` with aks-mcp binary management and local server lifecycle (download, version validation, start/stop, health checks).
- Introduce dual-mode operation: MCP mode (enhanced) and Traditional mode (built-in toolsets), with mode-specific system prompts.
- Implement smart toolset refresh strategy with persisted mode state to avoid unnecessary refresh on repeated runs.
Expand Down
5 changes: 3 additions & 2 deletions src/aks-agent/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import find_packages, setup

VERSION = "1.0.0b2"
VERSION = "1.0.0b3"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand All @@ -24,8 +24,9 @@
]

DEPENDENCIES = [
"holmesgpt==0.12.6; python_version >= '3.10'",
"pytest-asyncio>=1.1.0",
Copy link
Member

@mainred mainred Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we install pytest-asyncio which seems to be for test?

Copy link
Member Author

@nilo19 nilo19 Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

"pydantic-core",
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pydantic-core dependency should include a version constraint for better dependency management and reproducible builds. Consider adding a minimum version or version range, e.g., 'pydantic-core>=2.0.0'.

Suggested change
"pydantic-core",
"pydantic-core>=2.0.0",

Copilot uses AI. Check for mistakes.
Copy link
Member

@feiskyer feiskyer Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested here, add a version constraint

"holmesgpt==0.12.6; python_version >= '3.10'",
]

with open1("README.rst", "r", encoding="utf-8") as f:
Expand Down
Loading