Skip to content

Conversation

@nilo19
Copy link
Member

@nilo19 nilo19 commented Sep 15, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings September 15, 2025 03:58
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @nilo19,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 15, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the pydantic-core dependency to the aks-agent extension and increments the version from 1.0.0b2 to 1.0.0b3. The changes also remove CODEOWNERS entries for the aks-agent extension.

  • Add pydantic-core as a new dependency for the aks-agent extension
  • Update version from 1.0.0b2 to 1.0.0b3
  • Remove CODEOWNERS entry for the aks-agent extension

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/aks-agent/setup.py Updates version and reorganizes dependencies, adding pydantic-core
src/aks-agent/.gitignore Adds Poetry-related files to gitignore
.github/CODEOWNERS Removes the aks-agent extension ownership entry

DEPENDENCIES = [
"holmesgpt==0.12.6; python_version >= '3.10'",
"pytest-asyncio>=1.1.0",
"pydantic-core",
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pydantic-core dependency should include a version constraint for better dependency management and reproducible builds. Consider adding a minimum version or version range, e.g., 'pydantic-core>=2.0.0'.

Suggested change
"pydantic-core",
"pydantic-core>=2.0.0",

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested here, add a version constraint

@github-actions
Copy link

github-actions bot commented Sep 15, 2025

@nilo19 nilo19 force-pushed the fix/aks-agent-dependency branch from 3ad0796 to 0c80da7 Compare September 15, 2025 04:10
@nilo19 nilo19 force-pushed the fix/aks-agent-dependency branch from 0c80da7 to 43a52f1 Compare September 15, 2025 04:12

DEPENDENCIES = [
"holmesgpt==0.12.6; python_version >= '3.10'",
"pytest-asyncio>=1.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we install pytest-asyncio which seems to be for test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove

@feiskyer
Copy link
Member

@nilo19 there are conflicts need to be resolved

@nilo19 nilo19 closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants