Social | Classic editor connections schema changes #41778

manzoorwanijk · 2025-02-13T09:59:00Z

This PR contains all the changes we need for classic editor to use the new schema.

Proposed changes:

The commits in the PR are sequential and iterate over each other. You can go through them individually to see how things changed.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Install and activate the Classic Editor plugin on your site
For Simple sites you can activate the classic view from View Options at the top
Add some Social connections to the site
Create a post using classic editor
Confirm that the connections are loaded fine
Publish a post sharing only to some of the connections, leaving some unchecked
Confirm that the post gets shared only to the selected connections
Edit the same post again
Confirm that all the connections are now unchecked by default
Enable a connection and reshare the post
Confirm that the post is reshared to the selected connections and not to the other connections
Break a connection by removing Jetpack from connected apps on a network
On the social admin page, update a connection to update connection test cache
Open the Network tab
Load the classic editor again
Confirm that the connection tests use the wpcom/v2 endpoint instead of Ajax
Confirm that you see the broken connection notice
Do a sanity check for block editor to see connections work as expected for both new and existing posts

github-actions · 2025-02-13T09:59:52Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-classic-editor-schema-changes branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-classic-editor-schema-changes

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-02-13T10:00:01Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-02-13T10:10:16Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/lib/core-api/wpcom-fields/post-fields-publicize-connections.php	91/178 (51.12%)	-30.34%	54 💔
projects/plugins/jetpack/_inc/lib/core-api/class-wpcom-rest-field-controller.php	65/160 (40.62%)	-3.12%	5 💔

Full summary · PHP report · JS report

_{Add label

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
to override the failing coverage check.}

Since publicize package will always be the latest version regardless of whether there is an older version of a plugin, we can safely remove it.

projects/packages/publicize/src/class-publicize-base.php

pablinos

A few thoughts! But generally it's looking good

projects/packages/publicize/src/class-publicize-base.php

pablinos · 2025-02-14T10:26:17Z

projects/packages/publicize/src/class-publicize-base.php

@@ -971,7 +969,7 @@ public function get_filtered_connection_data( $selected_post_id = null ) {
 				 * If this is a global connection and this user doesn't have enough permissions to modify
 				 * those connections, don't let them change it.
 				 */
-				if ( ! $done && $this->is_global_connection( $connection_meta ) && ! current_user_can( $this->GLOBAL_CAP ) ) {
+				if ( ! $done && $connection['shared'] && ! current_user_can( $this->GLOBAL_CAP ) ) {


Should we have a is_shared method on the connection or something, so we remove the chance of typos etc? We're also mixing terms 'shared' and 'global'. It would be good to make sure we're only using one of those.

Yeah, we can add a method to the connections class to check if a connection is shared.

projects/packages/publicize/src/class-publicize-base.php

pablinos · 2025-02-14T10:33:43Z

projects/packages/publicize/src/class-publicize-ui.php

 					<?php
-						checked( true, $connection_data['enabled'] && $connection_healthy );
-						disabled( false, $connection_healthy );


This is an interesting flaw currently. If we know that the connection is broken from the last test, then we should update the cache to show that. Currently the cache might have all connections with an ok status, but the test-connections call then disabled it.

I think it's probably a follow-up though. It's how it also works in the block editor, but should we remove this disabled logic? Might it be better to update it to check that the status is ok?

As mentioned above, the status is by default null until connection tests are run.

May be in a separate change, we should use that connection test result call to save the connections list and then we could use the status field from there.

Yes, I don't think it's for this change, but we don't actually store the status of the connections now do we? So in the frontend, that's only reflected after the test connections call. I think we should update the connections cache with the result from the test connections call, and that should mean things update and jump around less.

We might want to check we're storing the status of the connections properly on WPCOM too, or we will try and share to broken connections. I think this bit is fine, but something to check while we're at it.

Yeah, WPCOM part is going to be tricky.

projects/packages/publicize/src/class-publicize-ui.php

projects/packages/publicize/src/js/classic-editor-connections.js

projects/packages/publicize/src/class-publicize-base.php

pablinos · 2025-02-14T10:48:34Z

projects/packages/publicize/src/class-publicize-ui.php

@@ -449,7 +449,7 @@ public function post_page_metabox() {
 				$labels = array();

 				foreach ( $connections_data as $connection_data ) {
-					if ( ! $connection_data['enabled'] || ( isset( $connection_data['is_healthy'] ) && false === $connection_data['is_healthy'] ) ) {
+					if ( ! $connection_data['enabled'] ) {


Should we be checking that the status is ok too?

status by default is null and is now set only on connection test results.

Right. Do you think it could be safer to check status here too? I feel like we should be storing that, so we'll just have to put this check back in when we do.

Yeah, we can put that that back when it's implemented.

projects/packages/publicize/src/class-publicize-base.php

jp-launch-control · 2025-02-14T11:41:05Z

Code Coverage Summary

Coverage changed in 7 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/packages/publicize/src/class-publicize-base.php	251/679 (36.97%)	-12.82%	74 💔
projects/plugins/jetpack/_inc/lib/core-api/wpcom-fields/post-fields-publicize-connections.php	91/178 (51.12%)	-30.34%	54 💔
projects/packages/publicize/src/rest-api/class-connections-post-field.php	114/181 (62.98%)	-19.83%	34 💔
projects/packages/publicize/src/class-publicize.php	64/297 (21.55%)	-2.36%	7 💔
projects/plugins/jetpack/_inc/lib/core-api/class-wpcom-rest-field-controller.php	65/160 (40.62%)	-3.12%	5 💔

Full summary · PHP report · JS report

_{Add label

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
to override the failing coverage check.}

pablinos

This is working pretty well for me. I've not tested it in all environments yet though. Perhaps we could each take one of those to make sure it works as expected?

gmjuhasz

Finally I could test it on Atomic too and seems to work fine

manzoorwanijk added 5 commits February 13, 2025 15:26

Update Publicize::get_filtered_connection_data()

6efd397

Update connection tests logic

aa33621

Remove Publicize_UI::get_must_reauth_connections method

f9651f3

Get rid of Publicize_UI::get_metabox_form_disconnected

71c2f02

Remove the usage of deprecated fields

046d5c1

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Status] In Progress labels Feb 13, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 13, 2025

manzoorwanijk added 3 commits February 13, 2025 17:37

Remove ajax action

6599b4a

Since publicize package will always be the latest version regardless of whether there is an older version of a plugin, we can safely remove it.

Skip irrelevant tests

e811958

Add changelog

fc36754

manzoorwanijk mentioned this pull request Feb 13, 2025

Social | Update classic editor connections schema #41779

Closed

3 tasks

github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Feb 13, 2025

manzoorwanijk changed the title ~~Update/social classic editor schema changes~~ Social | Classic editor connections schema changes Feb 13, 2025

manzoorwanijk added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 13, 2025

manzoorwanijk self-assigned this Feb 13, 2025

manzoorwanijk marked this pull request as ready for review February 13, 2025 12:17

manzoorwanijk requested a review from a team February 13, 2025 12:17

Fix lints

61a0061

manzoorwanijk added the [Type] Task label Feb 13, 2025

One more lint fix

5ebf11e

manzoorwanijk commented Feb 13, 2025

View reviewed changes

projects/packages/publicize/src/class-publicize-base.php Show resolved Hide resolved

pablinos reviewed Feb 14, 2025

View reviewed changes

Create and use Connections::is_shared method

ec01f31

pablinos reviewed Feb 16, 2025

View reviewed changes

manzoorwanijk added 4 commits February 17, 2025 09:49

Fix invalid connection logic to not disable must-reauth connections

eb2611b

Merge branch 'trunk' into update/social-classic-editor-schema-changes

85d5286

Skip irrelevant tests

653ddad

Merge branch 'trunk' into update/social-classic-editor-schema-changes

21ea258

gmjuhasz approved these changes Feb 18, 2025

View reviewed changes

manzoorwanijk merged commit 239a660 into trunk Feb 18, 2025
63 of 64 checks passed

manzoorwanijk deleted the update/social-classic-editor-schema-changes branch February 18, 2025 11:19

github-actions bot removed [Status] In Progress [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Feb 18, 2025

manzoorwanijk mentioned this pull request Feb 18, 2025

Social | Fix PHP warnings by removing unused fields in connection post field endpoint #41869

Merged

3 tasks

zinigor added this to the jetpack/14.4 milestone Feb 19, 2025

Social | Classic editor connections schema changes #41778

Social | Classic editor connections schema changes #41778

Uh oh!

Conversation

manzoorwanijk commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Uh oh!

pablinos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jp-launch-control bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

pablinos left a comment

Choose a reason for hiding this comment

Uh oh!

gmjuhasz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

manzoorwanijk commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 13, 2025 •

edited

Loading

jp-launch-control bot commented Feb 14, 2025 •

edited

Loading