Social | Fix PHP warnings by removing unused fields in connection post field endpoint

[manzoorwanijk]

In #41778, we updated the Connections_Post_Field class in publicize package to use the updated schema but its previous version inside Jetpack plugin seems to be used on WPCOM.

We have a task to remove that class but let us fix the issue on hand for now.

We removed these fields from the connection data in that class, we need to do the same in that Jetpack one to fix the warning

Warning: Undefined array key "unique_id" in
/.../_inc/lib/core-api/wpcom-fields/post-fields-publicize-connections.php on line 251

Proposed changes:

• Remove the unused fields from WPCOM_REST_API_V2_Post_Publicize_Connections_Field class.
• Sync the schema from Connections_Post_Field class in publicize package

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• On production wpcom
• Point your simple site and the public API to your sandbox
• Run tail -f /tmp/php-errors
• Goto block editor
• Notice the PHP error mentioned above
• Now apply the PR to your sandbox
• Goto block editor again
• Confirm that there are no PHP errors
• Open Jetpack sidebar
• Confirm that the connections load fine for both new and existing posts
• Publish a post to confirm it gets shared
• Reshare a post to confirm it works fine

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/wpcom-social-php-warnings branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/wpcom-social-php-warnings
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/lib/core-api/wpcom-fields/post-fields-publicize-connections.php	64/147 (43.54%)	-7.59%	-4 💚

Full summary · PHP report · JS report

[manzoorwanijk]

These schema changes are necessary to ensure that the fields are as per our schema because the fields are filtered below based on the schema.

[gmjuhasz]

I do not see the warnings in the logs and the post sharing went though