This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Move to using mainline CSSLint #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Travis CI configuration: * Use Trusty based builds * Remove OS X builds as they are unusably long to queue * Update dependent APT packages
This code is now linted using ESLint not CoffeeLint.
Bring in `jasmine-fix` to allow the use of `async`/`await` in the specs, and refactor them to take advantage of this.
Rewrite the provider to use mainline csslint instead of the custom fork. Includes: * BREAKING: Disabling of linting on changes * Updating to Linter v2 API * Allowing users to specify the path to CSSLint. Uses project local first, bundled second if not specified.
This no longer needs to load on package load, defer to loading in loadDeps().
This was referenced Aug 26, 2017
Closed
Arcanemagus
commented
Aug 26, 2017
| const exec = path.join(__dirname, '..', 'node_modules', 'atomlinter-csslint', 'cli.js'); | ||
|
|
||
| const parameters = [ | ||
| '--format=json', |
There was a problem hiding this comment.
Note, requires CSSLint v1.0.0 minimum for this functionality. We might need a check for this if users start filing many support requests about broken versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the provider to use mainline
csslintinstead of the custom fork.Includes:
csslintas it changes.csslintif it exists first, and uses the bundled copy second if this option is not specified.disableTimeoutoption any longer.jasmine-fix.Fixes #67.
Fixes #91.
Fixes #105.
Closes #165.
Fixes #166.