Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Remove dependency on custom fork of CSSLint #91

Closed
sergeychernyshev opened this issue Feb 25, 2016 · 10 comments · Fixed by #170
Closed

Remove dependency on custom fork of CSSLint #91

sergeychernyshev opened this issue Feb 25, 2016 · 10 comments · Fixed by #170

Comments

@sergeychernyshev
Copy link

Looks like this package depends on a custom fork of CSSLint (https://www.npmjs.com/package/atomlinter-csslint / https://github.com/AtomLinter/csslint).

This does not allow for getting newer versions of CSSLint coming from https://github.com/CSSLint/csslint

I contributed to core project - documentation URLs to all the rules and looked to surface them in Atom linter so developers can click right from message bubbles and open detailed documentation in the browser .

@Arcanemagus
Copy link
Member

It would be absolutely amazing to be able to use the main project (especially now that development is (slowly) moving again on it), but as you guess from filing CSSLint/csslint#642 (and missing CSSLint/csslint#606 😛) csslint isn't at a state where this can be done yet.

Btw, we also need CSSLint/csslint#605 to be merged in before we can switch back to the main repo.

@Arcanemagus
Copy link
Member

Btw, are you interested in becoming a maintainer of this project? I do what I can when I have time here, but there is currently no dedicated maintainer.

@sergeychernyshev
Copy link
Author

@Arcanemagus can't go as far as becoming a full maintainer - have my small itch to scratch at the moment and will give it some time though.

@sergeychernyshev
Copy link
Author

I see that there are a bunch of changes in the fork - is JSON formatter the only dependency?

@Arcanemagus
Copy link
Member

JSON formatter and stdin support, as mentioned.

@sergeychernyshev
Copy link
Author

Sorry, I missed the point that CSSLint/csslint#605 is for stdin support.

@Arcanemagus
Copy link
Member

The alternative approach would be to use the XML formatter, and move back to disabling lintOnFly and only linting on save. I personally don't want anything to do with that though, so...

@sergeychernyshev
Copy link
Author

I wouldn't want to limit the functionality - liked how it works right now pretty much.

@Arcanemagus
Copy link
Member

v1.0.0 is out, anyone interested in updating this to that?

@Arcanemagus
Copy link
Member

#170 moves to utilizing the mainline CSSLint... and disables the ability to lint on changes in the file as CSSLint still doesn't support stdin input 2 years later.

As (understandably) nobody is interested in maintaining the csslint fork here, this is the only option that allows users to have an up to date version of CSSLint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants