Skip to content

Httptest3 #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
havetisyan merged 8 commits into from
Jan 6, 2026
Merged

Httptest3 #3167

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc9299a
httptest implemented
frumioj Jan 2, 2026
cc6c023
httptest implemented
frumioj Jan 2, 2026
7309487
JSON variabnle name was incorrect
frumioj Jan 2, 2026
db3b217
Update provider/github/sia-actions/authn_test.go
frumioj Jan 4, 2026
0880118
Revert variable name
frumioj Jan 4, 2026
d1289dc
Use data not value in returned value
frumioj Jan 4, 2026
cd314b0
Merge branch 'AthenZ:master' into httptest3
frumioj Jan 5, 2026
60950a9
format error
frumioj Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 20 additions & 23 deletions provider/github/sia-actions/authn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,38 +19,35 @@ package sia
import (
"crypto/rand"
"crypto/rsa"
"github.com/gorilla/mux"
"github.com/stretchr/testify/assert"
"io"
"log"
"net/http"
"net/http/httptest"
"os"
"testing"
"time"
)

func startHttpServer(uri, token string, statusCode int) {
router := mux.NewRouter()
router.HandleFunc("/oidc", func(w http.ResponseWriter, r *http.Request) {
func startHttpServer(token string, statusCode int) *httptest.Server {
router := http.NewServeMux()
router.HandleFunc("GET /oidc", func(w http.ResponseWriter, r *http.Request) {
log.Println("/oidc token endpoint is called")
w.WriteHeader(statusCode)
io.WriteString(w, "{\"value\": \""+token+"\"}")
}).Methods("GET")
})

err := http.ListenAndServe(uri, router)
if err != nil {
log.Fatal("ListenAndServe: ", err)
}
return httptest.NewServer(router)
}

func TestGetOIDCToken(t *testing.T) {

validToken := "eyJraWQiOiIwIiwiYWxnIjoiRVMyNTYifQ.eyJleHAiOjE3MDgwMjc4MTcsImlzcyI6Imh0dHBzOi8vdG9rZW4uYWN0aW9ucy5naXRodWJ1c2VyY29udGVudC5jb20iLCJhdWQiOiJodHRwczovL2F0aGVuei5pbyIsInJ1bl9pZCI6IjAwMDEiLCJlbnRlcnByaXNlIjoiYXRoZW56Iiwic3ViIjoicmVwbzphdGhlbnovc2lhOnJlZjpyZWZzL2hlYWRzL21haW4iLCJldmVudF9uYW1lIjoicHVzaCIsImlhdCI6MTcwODAyNDIxN30.ykt6O1mIjIjalTrmaU9AuSSsQghZ7Mx61gDsjVPHV0-SCqYpZNy7RtEbvgjKVCZ0kJ6BijH3aEf3EGArLHjTOQ"
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", "http://localhost:8081/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")

go startHttpServer("localhost:8081", validToken, http.StatusOK)
time.Sleep(2 * time.Second)
ts := startHttpServer(validToken, http.StatusOK)
defer ts.Close()

os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", ts.URL+"/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")

_, claims, err := GetOIDCToken("https://athenz.io")
assert.Nil(t, err)
Expand All @@ -68,7 +65,7 @@ func TestGetOIDCTokenEnvNotSet(t *testing.T) {
assert.Equal(t, "ACTIONS_ID_TOKEN_REQUEST_URL environment variable not set", err.Error())

// now let's set the request url but not the token
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", "http://localhost:8081/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", "http://localhost:0/oidc?type=jwt")
_, _, err = GetOIDCToken("https://athenz.io")
assert.NotNil(t, err)
assert.Equal(t, "ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable not set", err.Error())
Expand All @@ -78,11 +75,11 @@ func TestGetOIDCTokenEnvNotSet(t *testing.T) {

func TestGetOIDCTokenInvalidStatusCode(t *testing.T) {

os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", "http://localhost:8082/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")
ts := startHttpServer("test-token", http.StatusBadRequest)
defer ts.Close()

go startHttpServer("localhost:8082", "invalid-token", http.StatusBadRequest)
time.Sleep(2 * time.Second)
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", ts.URL+"/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")

_, _, err := GetOIDCToken("https://athenz.io")
assert.NotNil(t, err)
Expand All @@ -93,11 +90,11 @@ func TestGetOIDCTokenInvalidStatusCode(t *testing.T) {

func TestGetOIDCTokenInvalidToken(t *testing.T) {

os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", "http://localhost:8083/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")
ts := startHttpServer("invalid-token", http.StatusOK)
defer ts.Close()

go startHttpServer("localhost:8083", "invalid-token", http.StatusOK)
time.Sleep(2 * time.Second)
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_URL", ts.URL+"/oidc?type=jwt")
os.Setenv("ACTIONS_ID_TOKEN_REQUEST_TOKEN", "test-token")

_, _, err := GetOIDCToken("https://athenz.io")
assert.NotNil(t, err)
Expand Down
3 changes: 2 additions & 1 deletion provider/harness/sia-harness/authn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ func GetOIDCToken(audience, harnessUrl string) (string, map[string]interface{},
}

signatureAlgorithms := []jose.SignatureAlgorithm{jose.RS256, jose.RS384, jose.RS512, jose.PS256, jose.PS384, jose.PS512, jose.ES256, jose.ES384, jose.ES512, jose.EdDSA}
oidcToken := jsonData["data"].(string)

oidcToken := jsonData["value"].(string)
tok, err := jwt.ParseSigned(oidcToken, signatureAlgorithms)
if err != nil {
return "", nil, fmt.Errorf("unable to parse oidc token: %v", err)
Expand Down
38 changes: 17 additions & 21 deletions provider/harness/sia-harness/authn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,24 @@ package sia
import (
"crypto/rand"
"crypto/rsa"
"github.com/gorilla/mux"
"github.com/stretchr/testify/assert"
"io"
"log"
"net/http"
"net/http/httptest"
"os"
"testing"
"time"
)

func startHttpServer(uri, token string, statusCode int) {
router := mux.NewRouter()
router.HandleFunc("/oidc", func(w http.ResponseWriter, r *http.Request) {
func startHttpServer(token string, statusCode int) *httptest.Server {
router := http.NewServeMux()
router.HandleFunc("POST /oidc", func(w http.ResponseWriter, r *http.Request) {
log.Println("/oidc token endpoint is called")
w.WriteHeader(statusCode)
io.WriteString(w, "{\"data\": \""+token+"\"}")
}).Methods("POST")
io.WriteString(w, "{\"value\": \""+token+"\"}")
})

err := http.ListenAndServe(uri, router)
if err != nil {
log.Fatal("ListenAndServe: ", err)
}
return httptest.NewServer(router)
}

func TestGetOIDCToken(t *testing.T) {
Expand All @@ -56,10 +52,10 @@ func TestGetOIDCToken(t *testing.T) {
os.Setenv("HARNESS_TRIGGER_TYPE", "manual")
os.Setenv("HARNESS_SEQUENCE_ID", "1")

go startHttpServer("localhost:8081", validToken, http.StatusOK)
time.Sleep(2 * time.Second)
ts := startHttpServer(validToken, http.StatusOK)
defer ts.Close()

_, claims, err := GetOIDCToken("https://athenz.io", "http://localhost:8081/oidc")
_, claims, err := GetOIDCToken("https://athenz.io", ts.URL+"/oidc")
assert.Nil(t, err)
assert.Equal(t, "https://athenz.io", claims["aud"].(string))
assert.Equal(t, "account/1234:org/athenzorg:project/athenz:pipeline/job-uuid", claims["sub"].(string))
Expand All @@ -75,7 +71,7 @@ func TestGetOIDCToken(t *testing.T) {
func TestGetOIDCTokenEnvNotSet(t *testing.T) {

// both env variables missing - first check is for request url
_, _, err := GetOIDCToken("https://athenz.io", "http://localhost:8081/oidc")
_, _, err := GetOIDCToken("https://athenz.io", "http://localhost:0/oidc")
assert.NotNil(t, err)
assert.Equal(t, "HARNESS_OIDC_API_KEY environment variable not set", err.Error())

Expand All @@ -93,10 +89,10 @@ func TestGetOIDCTokenInvalidStatusCode(t *testing.T) {
os.Setenv("HARNESS_TRIGGER_TYPE", "MANUAL")
os.Setenv("HARNESS_SEQUENCE_ID", "5")

go startHttpServer("localhost:8082", "invalid-token", http.StatusBadRequest)
time.Sleep(2 * time.Second)
ts := startHttpServer("invalid-token", http.StatusBadRequest)
defer ts.Close()

_, _, err := GetOIDCToken("https://athenz.io", "http://localhost:8082/oidc")
_, _, err := GetOIDCToken("https://athenz.io", ts.URL+"/oidc")
assert.NotNil(t, err)
assert.Equal(t, "oidc token get status error: 400", err.Error())

Expand All @@ -114,10 +110,10 @@ func TestGetOIDCTokenInvalidToken(t *testing.T) {
os.Setenv("HARNESS_TRIGGER_TYPE", "MANUAL")
os.Setenv("HARNESS_SEQUENCE_ID", "5")

go startHttpServer("localhost:8083", "invalid-token", http.StatusOK)
time.Sleep(2 * time.Second)
ts := startHttpServer("invalid-token", http.StatusOK)
defer ts.Close()

_, _, err := GetOIDCToken("https://athenz.io", "http://localhost:8083/oidc")
_, _, err := GetOIDCToken("https://athenz.io", ts.URL+"/oidc")
assert.NotNil(t, err)
assert.Equal(t, "unable to parse oidc token: go-jose/go-jose: compact JWS format must have three parts", err.Error())

Expand Down