Httptest3

[frumioj]

Description

Further net/httptest package usage, and apparent bug in json map

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @frumioj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the testing framework for OIDC token retrieval across both GitHub and Harness providers. By adopting Go's native net/http/httptest package, the tests now benefit from a more robust, isolated, and efficient HTTP server mocking mechanism. Crucially, it also includes a fix for correctly extracting the OIDC token from JSON responses, addressing a parsing discrepancy that could lead to incorrect token handling.

Highlights

• Test Infrastructure Refactor: The HTTP server mocking in various tests has been refactored to utilize Go's net/http/httptest package, replacing manual server setup and gorilla/mux.
• OIDC Token Parsing Fix: An apparent bug in the OIDC token parsing logic has been resolved by changing the expected JSON key for the token from 'data' to 'value'.
• Improved Test Reliability and Speed: The use of httptest.Server eliminates the need for time.Sleep calls, making tests more reliable and faster by ensuring the server is ready before tests proceed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[frumioj]

Should fully resolve #3149

[gemini-code-assist]

Code Review

The pull request refactors OIDC token retrieval tests in both github/sia-actions and harness/sia-harness packages. The startHttpServer helper function was updated to utilize net/http/httptest for creating isolated test servers, replacing gorilla/mux and explicit http.ListenAndServe calls, which eliminated the need for time.Sleep and fixed port assignments. This also involved changing the expected JSON key for the OIDC token from "data" to "value" in the harness package. A review comment suggested further improving test isolation by using t.Setenv() instead of os.Setenv() for setting environment variables within tests, ensuring automatic cleanup.