Conversation
Member
HyunJiLim0406
left a comment
HyunJiLim0406
left a comment
There was a problem hiding this comment.
p3
수고하셨습니다! 4문제 다 잘 푸셨네요~
근데 소소하게 리팩토링 할 부분들이 보여요!
조금만 수정하고 리뷰어로 저 호출해주세요
9월 23일 - 정수론 및 조합론/11050.cpp
Outdated
Comment on lines
10
to
19
Member
There was a problem hiding this comment.
이 문제는 간단해서 이렇게 풀어도 괜찮지만, 사실 이건 하드코딩에 가깝습니다!
이항계수 공식이나 파스칼의 삼각형을 이용해서 코드를 정리하는게 좋아요
9월 23일 - 정수론 및 조합론/2841.cpp
Outdated
Comment on lines
28
to
29
9월 23일 - 정수론 및 조합론/2841.cpp
Outdated
Comment on lines
17
to
22
Member
There was a problem hiding this comment.
이 두 조건도 같은 일을 하고 있으니 합칠 수 있구요!
9월 23일 - 정수론 및 조합론/6588.cpp
Outdated
Comment on lines
10
to
11
Member
There was a problem hiding this comment.
숫자를 바로 쓰는 것보단 상수로 선언해서 쓰는게 좋아요!
9월 23일 - 정수론 및 조합론/6588.cpp
Outdated
Comment on lines
12
to
19
Member
There was a problem hiding this comment.
이 부분은 에라토스테네스의 체 연산 부분이니 함수로 만들어주세요
9월 23일 - 정수론 및 조합론/6588.cpp
Outdated
Comment on lines
27
to
28
Member
There was a problem hiding this comment.
n/2까지만 돌아도 된다는걸 캐치하셨네요! 3부터 시작해도 된다는 것두요!
근데 연산을 줄일 수 있는 방법이 하나 더 있어요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.