Skip to content

fix: [AI-1838] map BigInteger to string in Perspective for large int precision #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralphstodomingo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: [AI-1838] map BigInteger to string in Perspective for large int precision #1851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions webview_panels/src/modules/queryPanel/components/perspective/PerspectiveViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
import perspective, { TableData } from "@finos/perspective";
import "@finos/perspective-viewer";
import "@finos/perspective-viewer-datagrid";
import "@finos/perspective-viewer-d3fc";
import {
HTMLPerspectiveViewerElement,
PerspectiveViewerConfig,
} from "@finos/perspective-viewer";
import "./themes.css";
import "@finos/perspective-viewer/dist/css/pro.css";
import "@finos/perspective-viewer-d3fc";
import "@finos/perspective-viewer-datagrid";
import "@finos/perspective-viewer/dist/css/monokai.css";
import "@finos/perspective-viewer/dist/css/pro-dark.css";
import "@finos/perspective-viewer/dist/css/vaporwave.css";
import "@finos/perspective-viewer/dist/css/solarized.css";
import "@finos/perspective-viewer/dist/css/pro.css";
import "@finos/perspective-viewer/dist/css/solarized-dark.css";
import "@finos/perspective-viewer/dist/css/monokai.css";
import "./PerspectivePlugins";
import { CSSProperties, useEffect, useRef, useState } from "react";
import { panelLogger } from "@modules/logger";
import useAppContext from "@modules/app/useAppContext";
import classes from "./perspective.module.scss";
import perspectiveStyles from "./perspective.scss?inline";
import "@finos/perspective-viewer/dist/css/solarized.css";
import "@finos/perspective-viewer/dist/css/vaporwave.css";
import { executeRequestInAsync } from "@modules/app/requestExecutor";
import useQueryPanelState from "@modules/queryPanel/useQueryPanelState";
import { useQueryPanelDispatch } from "@modules/queryPanel/QueryPanelProvider";
import useAppContext from "@modules/app/useAppContext";
import { panelLogger } from "@modules/logger";
import { setPerspectiveTheme } from "@modules/queryPanel/context/queryPanelSlice";
import { useQueryPanelDispatch } from "@modules/queryPanel/QueryPanelProvider";
import useQueryPanelState from "@modules/queryPanel/useQueryPanelState";
import { Drawer, DrawerRef } from "@uicore";
import { CSSProperties, useEffect, useRef, useState } from "react";
import { useErrorBoundary } from "react-error-boundary";
import classes from "./perspective.module.scss";
import perspectiveStyles from "./perspective.scss?inline";
import "./PerspectivePlugins";
import "./themes.css";

interface Props {
data: TableData;
Expand Down Expand Up @@ -65,7 +65,9 @@ const PerspectiveViewer = ({
case "Text":
return "string";
case "Integer":
return "float";
return "integer";
case "BigInteger":
return "string";
case "Number":
return "float";
default:
Expand Down Expand Up @@ -175,7 +177,6 @@ const PerspectiveViewer = ({
for (let i = 0; i < columnNames.length; i++) {
schema[columnNames[i]] = mapType(columnTypes[i]);
}

try {
// @ts-expect-error valid parameter
const worker = perspective.worker(dataFormats);
Expand Down
Loading