fix: [AI-1838] map BigInteger to string in Perspective for large int precision#1851
fix: [AI-1838] map BigInteger to string in Perspective for large int precision#1851ralphstodomingo wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReordered side-effect imports and CSS theme load order for Perspective viewer; changed column type mapping so Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is there any impact on the perspective features (sidebar) because we mark it to string, what about aggregation? |
|
Is there any upgrades we can do of perspective that would support bigint type? |
Only columns flagged as BigInteger (containing values > 2^53-1) use string rendering. Normal integer columns retain numeric type for proper sorting and aggregation. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
418b917 to
84aa752
Compare
Summary
BigIntegeragate type to Perspectivestringfor full precision renderingIntegermapped tointegerfor normal numeric behavior (sorting, aggregation)Context
Fixes #1838
The Python bridge now flags columns containing values > 2^53-1 as
BigIntegerinstead ofNumber/Integer. This PR adds the frontend mapping so only those columns use string rendering. Normal integer columns retain numeric type with proper sorting and aggregation.Trade-offs:
BigIntegercolumns supportcount/distinct countaggregation only — nosum/avg. This is preferable to showing incorrect rounded values.Companion PR: AltimateAI/altimate-dbt-integration#39 (Python-side precision preservation)
Test plan
9203817354237048492) displays with full precision🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
New Features
Chores