feat(makefile): add capability to skip Docker image pull #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
=======================================
Coverage ? 61.94%
=======================================
Files ? 92
Lines ? 3760
Branches ? 0
=======================================
Hits ? 2329
Misses ? 1431
Partials ? 0 ☔ View full report in Codecov by Sentry. |
basedanarki
reviewed
May 9, 2024
basedanarki
approved these changes
May 9, 2024
rbren
approved these changes
May 9, 2024
|
LGTM! |
@basedanarki Hi, I don't quite understand your point. |
SmartManoj
reviewed
Jun 9, 2024
| @@ -14,6 +14,8 @@ jobs: | |||
| test-on-macos: | |||
| name: Test on macOS | |||
| runs-on: macos-13 | |||
| env: | |||
| INSTALL_DOCKER: '0' # Set to '0' to skip Docker installation | |||
There was a problem hiding this comment.
Why is it skipped?
actions/runner-images#2150 (comment)
There was a problem hiding this comment.
Just add it back here:
#2342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sandbox.pytotests/integrationdue to its specialized test environment, so a new step was added to the unit test workflow.