-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgraded Python version to 3.12.3 #2331
Conversation
3.12.3 might be better pydantic/pydantic#9609 (comment) |
For non-docker method, we are currently using 3.11 only. It will avoid confusion for new users. |
AFAIK, we were using 3.12, when eventually we found out too many users were running into an issue with a Chroma dependency on 3.12, and we have downgraded for that reason, temporarily. I would personally favor keeping 3.12 as much as we can, and go the other way around: hope to fix issues that prevent the upgrade, rather than continue downgrading. That said ... it is a bit weird at this time. 😅 |
If 3.12.3 solves the problem I generally prefer going with newer versions of things myself. |
My fault for the confusion. I did think our mix of python versions was a bit too funny. But this is the full This is only an issue with building it, and there's a PR on pydantic so it will be fixed upstream. If we're okay with trying 3.12.3, this is a successful test for the edits suggested: |
Co-authored-by: Engel Nyst <[email protected]>
Co-authored-by: Engel Nyst <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Temporarily fixes #2330
Consistent with #885