Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded Python version to 3.12.3 #2331

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Conversation

SmartManoj
Copy link
Contributor

@SmartManoj SmartManoj commented Jun 8, 2024

Temporarily fixes #2330

Consistent with #885

@tobitege
Copy link
Collaborator

tobitege commented Jun 8, 2024

3.12.3 might be better pydantic/pydantic#9609 (comment)

@SmartManoj
Copy link
Contributor Author

SmartManoj commented Jun 8, 2024

Consistent with #885

For non-docker method, we are currently using 3.11 only. It will avoid confusion for new users.


Slack thread
image
@enyst

@enyst
Copy link
Collaborator

enyst commented Jun 8, 2024

AFAIK, we were using 3.12, when eventually we found out too many users were running into an issue with a Chroma dependency on 3.12, and we have downgraded for that reason, temporarily.

I would personally favor keeping 3.12 as much as we can, and go the other way around: hope to fix issues that prevent the upgrade, rather than continue downgrading.

That said ... it is a bit weird at this time. 😅

@neubig
Copy link
Contributor

neubig commented Jun 8, 2024

If 3.12.3 solves the problem I generally prefer going with newer versions of things myself.

containers/app/Dockerfile Outdated Show resolved Hide resolved
containers/app/Dockerfile Outdated Show resolved Hide resolved
@enyst
Copy link
Collaborator

enyst commented Jun 8, 2024

My fault for the confusion. I did think our mix of python versions was a bit too funny. But this is the full app image that people run, and it works as it is.

This is only an issue with building it, and there's a PR on pydantic so it will be fixed upstream.

If we're okay with trying 3.12.3, this is a successful test for the edits suggested:
https://github.com/enyst/OpenDevin/actions/runs/9431038477/job/25979245963?pr=6

@SmartManoj SmartManoj changed the title Downgrading Python version to stable 3.11 Downgraded Python version to 3.12.3 Jun 9, 2024
@SmartManoj SmartManoj requested a review from enyst June 9, 2024 03:01
@SmartManoj
Copy link
Contributor Author

#1664 (comment)

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmartManoj SmartManoj merged commit e0ad289 into All-Hands-AI:main Jun 9, 2024
2 checks passed
@SmartManoj SmartManoj deleted the docker1 branch June 9, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Publish Docker Image" CI workflow is failing
5 participants