fix(amf): correct QVBR quality direction - #1002
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (22)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (1)Sunshine 核心 C++ 源码,自托管游戏串流服务器。审查要点:内存安全、 线程安全、RAII 资源管理、安全漏洞。注意预处理宏控制的平台相关代码。⚙️ CodeRabbit configuration file Files:
🔇 Additional comments (22)
Summary by CodeRabbit
WalkthroughChanges该变更修正 AMF QVBR 质量等级的代码注释和多语言界面说明。数值方向统一为“越高质量越好”。代码逻辑、字段类型和默认值未改变。 AMF QVBR 质量说明
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This corrects QVBR quality guidance in the UI and configuration comments without changing encoding behavior. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (20 skipped: 20 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
改了啥呀
config.h和amf_config.h中写反的注释为啥要改
AMD AMF 定义的 QVBR Quality Level 是 1 最差、51 最好,但面板说明写成了越低越好。把这个方向写反的杂鱼文案拨正啦,免得用户按相反方向调画质。
Fixes #969
验证
ConvertFrom-Json解析全部 20 个 locale JSON:通过git diff --check:通过