Skip to content

fix(amf): correct QVBR quality direction - #1002

Merged
qiin2333 merged 1 commit into
masterfrom
fix/amf-qvbr-quality-description
Aug 28, 2026
Merged

fix(amf): correct QVBR quality direction#1002
qiin2333 merged 1 commit into
masterfrom
fix/amf-qvbr-quality-description

Conversation

@qiin2333

Copy link
Copy Markdown
Collaborator

改了啥呀

  • 把 20 个语言文件里的 AMF QVBR 品质方向统一改为“数值越高,质量越好”
  • 同步修正 config.hamf_config.h 中写反的注释
  • 保留现有滑块范围和编码器传值逻辑,不折腾本来就正确的运行时行为

为啥要改

AMD AMF 定义的 QVBR Quality Level 是 1 最差、51 最好,但面板说明写成了越低越好。把这个方向写反的杂鱼文案拨正啦,免得用户按相反方向调画质。

Fixes #969

验证

  • 使用 PowerShell ConvertFrom-Json 解析全部 20 个 locale JSON:通过
  • 扫描反向 QVBR 文案:无残留
  • git diff --check:通过

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 889d037c-cf5f-48be-864f-287f8c3b4132

📥 Commits

Reviewing files that changed from the base of the PR and between 750222a and 6d623ea.

📒 Files selected for processing (22)
  • src/amf/amf_config.h
  • src/config.h
  • src_assets/common/assets/web/public/assets/locale/bg.json
  • src_assets/common/assets/web/public/assets/locale/cs.json
  • src_assets/common/assets/web/public/assets/locale/de.json
  • src_assets/common/assets/web/public/assets/locale/en.json
  • src_assets/common/assets/web/public/assets/locale/en_GB.json
  • src_assets/common/assets/web/public/assets/locale/en_US.json
  • src_assets/common/assets/web/public/assets/locale/es.json
  • src_assets/common/assets/web/public/assets/locale/fr.json
  • src_assets/common/assets/web/public/assets/locale/it.json
  • src_assets/common/assets/web/public/assets/locale/ja.json
  • src_assets/common/assets/web/public/assets/locale/ko.json
  • src_assets/common/assets/web/public/assets/locale/pl.json
  • src_assets/common/assets/web/public/assets/locale/pt.json
  • src_assets/common/assets/web/public/assets/locale/pt_BR.json
  • src_assets/common/assets/web/public/assets/locale/ru.json
  • src_assets/common/assets/web/public/assets/locale/sv.json
  • src_assets/common/assets/web/public/assets/locale/tr.json
  • src_assets/common/assets/web/public/assets/locale/uk.json
  • src_assets/common/assets/web/public/assets/locale/zh.json
  • src_assets/common/assets/web/public/assets/locale/zh_TW.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Windows
🧰 Additional context used
📓 Path-based instructions (1)
Sunshine 核心 C++ 源码,自托管游戏串流服务器。审查要点:内存安全、 线程安全、RAII 资源管理、安全漏洞。注意预处理宏控制的平台相关代码。

⚙️ CodeRabbit configuration file

Files:

  • src/config.h
  • src/amf/amf_config.h
🔇 Additional comments (22)
src/amf/amf_config.h (1)

91-91: LGTM!

src/config.h (1)

79-79: LGTM!

src_assets/common/assets/web/public/assets/locale/bg.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/pt.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/pt_BR.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/ru.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/sv.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/tr.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/uk.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/zh.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/zh_TW.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/cs.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/de.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/en.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/en_GB.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/en_US.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/es.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/fr.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/it.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/ja.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/ko.json (1)

238-238: LGTM!

src_assets/common/assets/web/public/assets/locale/pl.json (1)

238-238: LGTM!


Summary by CodeRabbit

  • 文档
    • 修正 AMD QVBR 质量等级说明,明确数值越高代表质量越好。
    • 同步更新多种语言的界面提示文本,避免产生相反理解。
    • QVBR 取值范围、默认值及其他行为保持不变。

Walkthrough

Changes

该变更修正 AMF QVBR 质量等级的代码注释和多语言界面说明。数值方向统一为“越高质量越好”。代码逻辑、字段类型和默认值未改变。

AMF QVBR 质量说明

Layer / File(s) Summary
更新 AMF 配置注释
src/amf/amf_config.h, src/config.h
将 QVBR 质量等级注释从 lower=better 修正为 higher=better
更新多语言界面描述
src_assets/common/assets/web/public/assets/locale/*.json
修正 20 种语言中的 amd_qvbr_quality_desc 文本。范围、默认值和模式说明保持不变。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6d623

This corrects QVBR quality guidance in the UI and configuration comments without changing encoding behavior. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: yundi339

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (20 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了修正 AMF QVBR 质量方向的主要变更,简洁且具体。
Description check ✅ Passed 描述明确说明了 20 个语言文件及两个头文件中的 QVBR 文案修正,并说明未改变运行时逻辑。内容与变更相关。
Linked Issues check ✅ Passed PR 修正了所有涉及的 AMF QVBR 质量说明,使其表示数值越高质量越好,并覆盖头文件注释和 20 个语言文件,满足问题 #969 的主要目标。
Out of Scope Changes check ✅ Passed 所有变更均为 AMF QVBR 质量说明和注释修正。未发现超出问题 #969 范围的代码或行为变更。
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (20 skipped: 20 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/amf-qvbr-quality-description

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiin2333
qiin2333 merged commit 657dedb into master Aug 28, 2026
4 checks passed
@qiin2333
qiin2333 deleted the fix/amf-qvbr-quality-description branch August 28, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AMF 的 QVBR 碼率控制 說明敘述與實際相反

1 participant