Skip to content

WIP: fix(telescope) preview caching #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: fix(telescope) preview caching #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lua/neoclip/telescope.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ local function get_export(register_names, typ)
end,
dyn_title = function(self, entry)
return spec_from_entry(entry)
end,
get_buffer_by_name = function(self, entry)
return 'test'
Copy link

@fdschmidt93 fdschmidt93 Jan 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be unique by entry as it essentially sets the look-up key for a table of preview buffers. Nevertheless, I'm also a bit confused that this doesn't break preview 😅 I'll have to check some more.

return "neoclip_" .. entry.idx I think works (I looked briefly into this a couple of days ago).

This somewhat speeds up the preview for my; however it's still rather slow for some reason. I'll try to think about this some more.

Copy link
Owner Author

@AckslD AckslD Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fdschmidt93, really appreciate you're insight here :)

Yeah I was also surprised that the preview worked at all like this. I just put it like this first as a test and assumed that all previews would be the same, but it kept working and even seemed smoother when I tried it.

Copy link
Owner Author

@AckslD AckslD Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdschmidt93 just wondering if you had time to give this some thought :)

end
})
end
Expand Down