Skip to content

Conversation

@AckslD
Copy link
Owner

@AckslD AckslD commented Jan 9, 2022

No description provided.

@AckslD AckslD changed the title fix(telescope) preview caching WIP: fix(telescope) preview caching Jan 9, 2022
return spec_from_entry(entry)
end,
get_buffer_by_name = function(self, entry)
return 'test'
Copy link

@fdschmidt93 fdschmidt93 Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be unique by entry as it essentially sets the look-up key for a table of preview buffers. Nevertheless, I'm also a bit confused that this doesn't break preview 😅 I'll have to check some more.

return "neoclip_" .. entry.idx I think works (I looked briefly into this a couple of days ago).

This somewhat speeds up the preview for my; however it's still rather slow for some reason. I'll try to think about this some more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fdschmidt93, really appreciate you're insight here :)

Yeah I was also surprised that the preview worked at all like this. I just put it like this first as a test and assumed that all previews would be the same, but it kept working and even seemed smoother when I tried it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdschmidt93 just wondering if you had time to give this some thought :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants