Skip to content

Added restService based overload with CachedSchemaRegistryClient #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added restService based overload with CachedSchemaRegistryClient #365

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d00291b
Added restService based overload with CachedSchemaRegistryClient crea…
Sep 17, 2024
42c5610
Added restService based overload with CachedSchemaRegistryClient crea…
Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/scala/za/co/absa/abris/avro/registry/ConfluentRegistryClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

package za.co.absa.abris.avro.registry
import io.confluent.kafka.schemaregistry.client.rest.RestService
import io.confluent.kafka.schemaregistry.client.{CachedSchemaRegistryClient, SchemaRegistryClient}
import io.confluent.kafka.serializers.KafkaAvroDeserializerConfig

Expand All @@ -23,6 +24,10 @@ import scala.collection.JavaConverters._
class ConfluentRegistryClient(client: SchemaRegistryClient) extends AbstractConfluentRegistryClient(client) {

def this(configs: Map[String,String]) = this(ConfluentRegistryClient.createClient(configs))

def this(restService: RestService, maxSchemaObject: Int) = {
this(ConfluentRegistryClient.createClient(restService, maxSchemaObject))
}
}
Comment on lines +27 to 31
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Lets update the files where this class is being used.
  2. Add Test cases
  3. Add scaladoc for this in terms of how to use this constructor


object ConfluentRegistryClient {
Expand All @@ -35,4 +40,8 @@ object ConfluentRegistryClient {
new CachedSchemaRegistryClient(urls, maxSchemaObject, configs.asJava)
}

private def createClient(restService: RestService, maxSchemaObject: Int) = {
new CachedSchemaRegistryClient(restService, maxSchemaObject)
}

}