Skip to content

Conversation

@DwivediPrasoon
Copy link

@DwivediPrasoon DwivediPrasoon commented Sep 17, 2024

related to issue: #364

Basic auth doesn't seem to connect to Schema registry on CC using the basic auth method i.e.

AbrisConfig.fromConfluentAvro.downloadReaderSchemaByLatestVersion
          .andTopicNameStrategy(getTopic)
          .usingSchemaRegistry(
            Map(
              AbrisConfig.SCHEMA_REGISTRY_URL -> Configuration.schemaRegistryUrl,
              SchemaRegistryClientConfig.BASIC_AUTH_CREDENTIALS_SOURCE -> "USER_INFO",
              SchemaRegistryClientConfig.USER_INFO_CONFIG -> s"${Configuration.schemaRegistryUsername}:${Configuration.schemaRegistryPassword}"
            )
          )

but able to connect when used with restService constructor of CachedSchemaRegistryClient. This PR aims at giving an option to pass RestService object to be able to create CachedSchemaRegistryClient for it.

Comment on lines +27 to 31

def this(restService: RestService, maxSchemaObject: Int) = {
this(ConfluentRegistryClient.createClient(restService, maxSchemaObject))
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Lets update the files where this class is being used.
  2. Add Test cases
  3. Add scaladoc for this in terms of how to use this constructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants