Skip to content

SPR modifications to support api-v2 (Spack v1.x) #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
harshula wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

SPR modifications to support api-v2 (Spack v1.x) #332

harshula wants to merge 10 commits into from

Conversation

@harshula
Copy link
Collaborator

@harshula harshula commented Oct 8, 2025

DRAFT to track changes

@harshula harshula self-assigned this Oct 8, 2025
@github-project-automation github-project-automation bot moved this to New Issues 🌅 in Model Release Oct 8, 2025
@scheibelp scheibelp mentioned this pull request Oct 13, 2025
Closed
@harshula harshula force-pushed the api-v2 branch 2 times, most recently from d4f75a2 to 356ff3d Compare November 3, 2025 02:49
@CodeGat
Copy link
Member

CodeGat commented Nov 3, 2025 •
edited
Loading

Hey @harshula, the error is because of the changed directory structure for spack-packages between api-v1 and api-v2. Unfortunately I can't suggest changes directly because the bits I want to change are unmodified. But:

In https://github.com/ACCESS-NRI/spack-packages/blob/cc4ec27340bc179b1efade7c74938e49ea61d5b6/.github/workflows/ci.yml#L5, you need to change that to - spack_repo/access/nri/packages/**

In https://github.com/ACCESS-NRI/spack-packages/blob/cc4ec27340bc179b1efade7c74938e49ea61d5b6/.github/workflows/ci.yml#L51, change it to path: ./spack_repo/access/nri/packages

@CodeGat CodeGat moved this from New Issues 🌅 to In Progress 🏗️ in Spack `0.22` to `1.0` Migration Nov 3, 2025
@CodeGat CodeGat mentioned this pull request Nov 3, 2025
Merged
@CodeGat
Copy link
Member

CodeGat commented Nov 4, 2025

For the next run of checks @harshula, feel free to up the max-parallel to 5...just so it goes a bit quicker! The relevant line can be found here: https://github.com/ACCESS-NRI/spack-packages/pull/332/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL134

@harshula harshula force-pushed the api-v2 branch 4 times, most recently from 2bed8ad to 78b303f Compare November 4, 2025 02:37
@CodeGat
Copy link
Member

CodeGat commented Nov 4, 2025

Just noting that I've updated the upstream image in the cluster to :rocky-v1.0-2025.11.000, which contains the [email protected] target=x86_64 compiler.

@CodeGat
Copy link
Member

CodeGat commented Nov 5, 2025

@harshula, once this run is done, feel free to up the max-parallel to 7

@harshula harshula force-pushed the api-v2 branch 5 times, most recently from 763e051 to fb1e18e Compare November 11, 2025 10:40
@harshula harshula force-pushed the api-v2 branch 2 times, most recently from 20abf09 to 4878de1 Compare December 4, 2025 09:09
@harshula
Copy link
Collaborator Author

harshula commented Dec 4, 2025

5 (expected) failures: https://github.com/ACCESS-NRI/access-spack-packages/actions/runs/19923566643?pr=332
IIRC, gcom, gcom4 and um need to access the Gadi filesystem, hence CI can not build them.

@CodeGat
Copy link
Member

CodeGat commented Dec 4, 2025

So you're saying...that's that? It works? 😲

@CodeGat CodeGat mentioned this pull request Dec 4, 2025
Merged
4 tasks
@harshula harshula force-pushed the api-v2 branch 2 times, most recently from e7c81c5 to 906c165 Compare December 14, 2025 13:49
@harshula harshula force-pushed the api-v2 branch 2 times, most recently from bd937dd to 2849be1 Compare December 15, 2025 10:40
@harshula harshula force-pushed the api-v2 branch 6 times, most recently from 58dedf3 to f571b78 Compare December 17, 2025 00:58
@CodeGat
Copy link
Member

CodeGat commented Dec 17, 2025

@harshula 🥳

@aidanheerdegen aidanheerdegen mentioned this pull request Jan 28, 2026
Merged
harshula and others added 10 commits January 28, 2026 23:06
@harshula
Make package directory names API v2.0 compliant
dcef695 
* Hyphen is replaced by underscore.
@harshula
spack repo migrate --fix
d506fe1
@harshula
access_mocsy, access3_share, mom5: fix namespace
f8ed93e
@harshula
Support Spack v1.0 compilers as a package
d5d4255
@harshula
Support Spack v1.0 by depending on languages
f02d5c5
@harshula
Make directory path API v2.0 compliant
6aea8fd
@harshula
module llnl has been moved to spack.llnl
b0af2c0 
* https://github.com/spack/spack/ PR 50989
@harshula
Add __init__.py files and spack-repo-index.yaml
8d7a9c8 
* __init__.py: review feedback from Peter Scheibel.
* spack-repo-index.yaml: suggested by Tommy Gatti.
@harshula @CodeGat
CI: use Spack v1.1
f7d6214 
* .github/build-ci/data/standard_definitions.json:
  * Change syntax to suit toolchains
* Update spack.yaml templates to use Spack v1.x compiler toolchains syntax
* .github/workflows/ci.yml:
  * DEFAULT_SPACK_REF: 'releases/v1.1'
  * Disable gcom, gcom4 and um because they need Gadi
* Increase max-parallel to 7
* Remove access-om3 from manifests
* Set builtin-spack-packages-ref: 39aeb9dbcc13b6a53e40c77b672c397e1f4c93ec
* Add a generic intel-oneapi-compilers test
* %[email protected] can not compile the latest version of python
  * Require python 3.11.14.

* PR 346:
  * Update paths to `api-v2` format
  * Replace `_` from directory name with `-` for package names
  * Swap filepath and template_value so package name comes first in matrix
  * Consolidate all refs to packages path under env.PACKAGES_ROOT_DIR
* .github/workflows/ci.yml: disable SBRs

Co-authored-by: Tommy Gatti <[email protected]>
@CodeGat @harshula
build-ci v3: Update Infra For spack v1 (#353)
51afe62 
infra: Update to v3, get default spack-config-ref/spack-ref from build-ci workflow, use default container-image-version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@harshula harshula

Labels

None yet

Projects

ACCESS-NRI Infrastructure
Status: No status
Model Release
Status: New Issues 🌅
Spack `0.22` to `1.0` Migration
Status: In Progress 🏗️

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harshula @CodeGat