CI: Underscore to hyphen fix, small readability changes#346
Merged
Conversation
CodeGat
added
bug
harshula
reviewed
Nov 3, 2025
harshula
reviewed
Nov 3, 2025
harshula
reviewed
Nov 3, 2025
CodeGat
force-pushed
the
ci-underscore-fix
branch
from
673e705 to
5739f6c
Compare
harshula
force-pushed
the
api-v2
branch
4 times, most recently
from
2bed8ad to
78b303f
Compare
Swap filepath and template_value so package name comes first in matrix
CodeGat
force-pushed
the
ci-underscore-fix
branch
from
9f9900a to
a801721
Compare
harshula
reviewed
Nov 4, 2025
harshula
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently in #332, packages are being tested for compliance for changes in
spack v1.One of those changes is that the directory structure has changed, and package directories should have
_rather than-(so they are valid python modules). They are then converted back into their--style packages forspack.However, this means that the CI has been failing, because it has been using the
_package directories as package names, which doesn't work.I've also added some readability fixes to the matrix, so the name of the package comes first, rather than the filepath.
The PR
_from package directory name with-for package names intemplate_valuefilepathandtemplate_valuein matrix, so the package name is more visible in the CI on the webapi-v2format (I had missed theworkflow_dispatchcase!)