-
Notifications
You must be signed in to change notification settings - Fork 16
Tidal dissipation parameterisation #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This matches GFDL-OM5 except that these non-default values are missing: |
|
Ignore my previous comment - these are set in #556 |
aekiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @minghangli-uni
|
Thanks @aekiss ! Once the tidal forcing PR is merged, I’ll update |
478ebe3 to
82391a2
Compare
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/44d7453b92323f930131485cab8f43910f872c10/testing/checksum |
|
!test repro commit |
|
(Regenerating checksums with the new 6 hour run length) |
|
❌ |
Gadi is down unexpectedly.... |
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/44d7453b92323f930131485cab8f43910f872c10/testing/checksum |
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minghangli-uni. Can you confirm that the bottom_roughness.nc and tideamp.nc are correct for this bathymetry:
/g/data/vk83/prerelease/configurations/inputs/access-om3/share/grids/global.25km/2025.05.15
|
Also, I get U and V velocity truncations within the first month. Is that expected? |
From the histories, yes. |
Did that occur on the second day? That should be fine though. Also you are using greater timesteps in this PR. |
I'll didn't check the day sorry (and I've since cleaned up the test run) |
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minghang!
895e8dc to
6f3faba
Compare
…erisation 100km ryf config: Add parameterisations for tidal dissipation (#562)
…erisation-iaf 100km iaf config: Add parameterisations for tidal dissipation (#562)
100km RYF+WOMBATlite: Add parameterisations for tidal dissipation (#562)
1. Summary:
Tidal dissipation parameterisation
What has changed?
config.yaml
manifests/input.yaml
testing/checksum/historical-3hr-checksum.json
MOM_inputI’ll update the files in docs/ after #556 and ACCESS-NRI/om3-scripts#53 have been merged.
Why was this done?
Ensures physically realistic deep ocean mixing, supports overturning circulation, and enhances model fidelity in long-term coupled simulations.
2. Issues Addressed:
3. Depedencies (e.g. on payu, model or om3-scripts)
This change requires changes to (note required version where true):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.7. Documentation
The docs folder has been updated with output from running the model?
A PR has been created for updating the documentation?
8. Formatting
Changes to MOM_input have been copied from model output in docs/MOM_parameter_docs.short?
9. Merge Strategy