Skip to content

Conversation

@minghangli-uni
Copy link
Collaborator

1. Summary:
Ref: #771 (comment)
What has changed?
MOM_input, docs, docs/available_diags.000000, manifests/input.yaml

2. Issues Addressed:

3. Dependencies (e.g. on payu, model or om3-scripts)

This change requires changes to (note required version where true):

  • payu:
  • access-om3:
  • om3-scripts:

4. Ad-hoc Testing

What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?

5. CI Testing

  • !test repro has been run

6. Reproducibility

Is this reproducible with the previous commit? (If not, why not?)

  • Yes
  • No - !test repro commit has been run.

7. Documentation

The docs folder has been updated with output from running the model?

  • Yes
  • N/A

A PR has been created for updating the documentation?

  • Yes:
  • N/A

8. Formatting

Changes to MOM_input have been copied from model output in docs/MOM_parameter_docs.short?

  • Yes
  • N/A

9. Merge Strategy

  • Merge commit
  • Rebase and merge
  • Squash

@minghangli-uni minghangli-uni self-assigned this Sep 23, 2025
@minghangli-uni
Copy link
Collaborator Author

minghangli-uni commented Sep 23, 2025

Umm, some changes are not consistent with #779 because the iaf config hasnt updated 2ff857c, such as

#Model software version
modules:
    use:
        - /g/data/vk83/modules
    load:
        - access-om3/2025.08.001

@minghangli-uni
Copy link
Collaborator Author

!test repro commit

@github-actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 771-tidal-dissipation-parameterisation-iaf (checksums created using commit 125b1d3), against
  • dev-MC_100km_jra_iaf (checksums in commit 49e3f9c)

🔧 The new checksums will be committed to this PR, if they differ from what is on this branch.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/125b1d34bea80a6c6b40a366e63c01121cf52c0b, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/50990804041.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/17931890148/artifacts/4077812803.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/49e3f9c0a0162acb313853a5897a3435673db410/testing/checksum

Test summary:
test_repro_historical

@minghangli-uni minghangli-uni marked this pull request as ready for review September 23, 2025 00:12
@minghangli-uni
Copy link
Collaborator Author

@dougiesquire this is ready for review. Since 2ff857c hasn't been cherry-picked the changes are not consistent with #779

@dougiesquire
Copy link
Collaborator

Umm, some changes are not consistent with #779 because the iaf config hasnt updated 2ff857c, such as

#Model software version
modules:
    use:
        - /g/data/vk83/modules
    load:
        - access-om3/2025.08.001

Oh yeah - sorry. Maybe we should wait until @anton-seaice has updated to access-om3/2025.08.001

@dougiesquire
Copy link
Collaborator

@minghangli-uni can you rebase this now that #785 is merged and then ping me for approval :)

@minghangli-uni minghangli-uni force-pushed the 771-tidal-dissipation-parameterisation-iaf branch from e7e8ea7 to d6e369e Compare September 23, 2025 03:12
@minghangli-uni
Copy link
Collaborator Author

!test repro commit

@github-actions
Copy link

❌ The Bitwise Reproducibility Check Failed ❌

When comparing:

  • 771-tidal-dissipation-parameterisation-iaf (checksums created using commit d6e369e), against
  • dev-MC_100km_jra_iaf (checksums in commit 429a908)

🔧 The new checksums will be committed to this PR, if they differ from what is on this branch.

Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/d6e369ebfe1f9e0afca1cfeaa2bdd6ba994d1d37, and the test results at https://github.com/ACCESS-NRI/access-om3-configs/runs/50998783800.

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/17934676092/artifacts/4078680411.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/429a9084b1b3c5b1db869c697c41847a1c2c6563/testing/checksum

Test summary:
test_repro_historical

@dougiesquire
Copy link
Collaborator

Thanks @minghangli-uni. I've just pushed some updates to docs/available_diags.000000. It might be cleanest for you to do an interactive rebase and squash those into the "Add parameterisations for tidal dissipation (#562)" commit?

@dougiesquire
Copy link
Collaborator

I guess this change was also needed in #779. I'll open a small PR to fix that up now. Sorry for missing this!

@minghangli-uni minghangli-uni force-pushed the 771-tidal-dissipation-parameterisation-iaf branch from 70d29dc to 40ada58 Compare September 23, 2025 03:50
@minghangli-uni
Copy link
Collaborator Author

minghangli-uni commented Sep 23, 2025

I guess this change was also needed in #779.

I think I've done that in that PR and also this one, but forgot to run it and copy those files after rebase.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minghangli-uni!

@minghangli-uni
Copy link
Collaborator Author

I'll bypass and merge this. Thanks @dougiesquire !

@minghangli-uni minghangli-uni merged commit d5e8349 into dev-MC_100km_jra_iaf Sep 23, 2025
11 checks passed
@minghangli-uni minghangli-uni deleted the 771-tidal-dissipation-parameterisation-iaf branch September 23, 2025 03:55
@dougiesquire
Copy link
Collaborator

I guess this change was also needed in #779.

I think I've done that in that PR and also this one, but forgot to run it and copy those files after rebase.

Just noting that I checked this and yes the changes are already there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants