-
Notifications
You must be signed in to change notification settings - Fork 16
100km iaf config: Add parameterisations for tidal dissipation (#562) #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
100km iaf config: Add parameterisations for tidal dissipation (#562) #784
Conversation
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/49e3f9c0a0162acb313853a5897a3435673db410/testing/checksum Test summary: |
|
@dougiesquire this is ready for review. Since 2ff857c hasn't been cherry-picked the changes are not consistent with #779 |
Oh yeah - sorry. Maybe we should wait until @anton-seaice has updated to |
|
@minghangli-uni can you rebase this now that #785 is merged and then ping me for approval :) |
e7e8ea7 to
d6e369e
Compare
|
!test repro commit |
|
❌ The Bitwise Reproducibility Check Failed ❌ When comparing:
🔧 The new checksums will be committed to this PR, if they differ from what is on this branch. Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/429a9084b1b3c5b1db869c697c41847a1c2c6563/testing/checksum Test summary: |
|
Thanks @minghangli-uni. I've just pushed some updates to |
|
I guess this change was also needed in #779. I'll open a small PR to fix that up now. Sorry for missing this! |
70d29dc to
40ada58
Compare
I think I've done that in that PR and also this one, but forgot to run it and copy those files after rebase. |
dougiesquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minghangli-uni!
|
I'll bypass and merge this. Thanks @dougiesquire ! |
Just noting that I checked this and yes the changes are already there |
1. Summary:
Ref: #771 (comment)
What has changed?
MOM_input, docs, docs/available_diags.000000, manifests/input.yaml
2. Issues Addressed:
3. Dependencies (e.g. on payu, model or om3-scripts)
This change requires changes to (note required version where true):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.7. Documentation
The docs folder has been updated with output from running the model?
A PR has been created for updating the documentation?
8. Formatting
Changes to MOM_input have been copied from model output in docs/MOM_parameter_docs.short?
9. Merge Strategy