Skip to content

Frontend Cypress Test#94

Open
alyu201 wants to merge 45 commits into701-T4:mainfrom
alyu201:cypress
Open

Frontend Cypress Test#94
alyu201 wants to merge 45 commits into701-T4:mainfrom
alyu201:cypress

Conversation

@alyu201
Copy link
Copy Markdown
Contributor

@alyu201 alyu201 commented Mar 13, 2022

Description

Setup cypress and add tests for frontend related changes.

Fixes/resolves #87

Screenshots

Please include any screenshots or media that illustrates the changes made

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Leave blank if not applicable

I have completed these steps when making this pull request:

  • I have assigned my name to the issue
  • I have moved the issue to the In Progress column
  • I have labelled the PR appropriately
  • I have assigned myself to the PR

Before opening the PR for review:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have moved the linked issue to the Review in Progress column

@ywu666 ywu666 changed the title Cypress Frontend- Cypress Test Mar 13, 2022
@ywu666 ywu666 changed the title Frontend- Cypress Test Frontend Cypress Test Mar 13, 2022
@ywu666 ywu666 added the front-end related to front-end code label Mar 13, 2022
@alyu201 alyu201 added the enhancement enhancement of existing features label Mar 13, 2022
@alyu201 alyu201 requested a review from a team as a code owner March 17, 2022 05:39
@frasermcc9
Copy link
Copy Markdown
Contributor

Please add documentation somewhere on how to run these tests.

@j-chad
Copy link
Copy Markdown
Contributor

j-chad commented Mar 17, 2022

Please add documentation somewhere on how to run these tests.

pull from main first. I have just merged documentation update

@alyu201
Copy link
Copy Markdown
Contributor Author

alyu201 commented Mar 17, 2022

Please add documentation somewhere on how to run these tests.

Have added to the readme of the frontend dir. Not sure how and where to add to the root readme file so left it as is

Copy link
Copy Markdown

@conrad-scherb conrad-scherb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use data-cy to target specific DOM elements as per Cypress best practices.

@frasermcc9
Copy link
Copy Markdown
Contributor

It seems the tests do not pass consistently.

  • It seems that "delete the duplicate" commit broke some of the tests.
  • Some tests fail indeterminately, possibly the firebase api requests. These can take a while so you can try increasing the timings.

@j-chad
Copy link
Copy Markdown
Contributor

j-chad commented Mar 18, 2022

Shouldnt third party deps be mocked out?

@frasermcc9 frasermcc9 mentioned this pull request Mar 19, 2022
14 tasks
@ywu666 ywu666 requested a review from frasermcc9 March 19, 2022 05:33
Copy link
Copy Markdown
Contributor

@yzhe819 yzhe819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve the conflicts, so I can approve it @alyu201

@ywu666 ywu666 requested a review from yzhe819 March 20, 2022 11:33
Copy link
Copy Markdown
Contributor

@brookeknowles brookeknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement enhancement of existing features front-end related to front-end code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Cypress and add tests for frontend

8 participants