Open
Conversation
…re/sharing-link
Contributor
|
Please add documentation somewhere on how to run these tests. |
Contributor
pull from main first. I have just merged documentation update |
Contributor
Author
Have added to the readme of the frontend dir. Not sure how and where to add to the root readme file so left it as is |
conrad-scherb
left a comment
There was a problem hiding this comment.
Use data-cy to target specific DOM elements as per Cypress best practices.
Contributor
|
It seems the tests do not pass consistently.
|
Contributor
|
Shouldnt third party deps be mocked out? |
yzhe819
approved these changes
Mar 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setup cypress and add tests for frontend related changes.
Fixes/resolves #87
Screenshots
Please include any screenshots or media that illustrates the changes made
Type of change
Please delete options that are not relevant.
Checklist:
Leave blank if not applicable
I have completed these steps when making this pull request:
Before opening the PR for review: