Skip to content

Add auth emulator#124

Merged
frasermcc9 merged 8 commits into701-T4:mainfrom
frasermcc9:framcc/auth-emulator
Mar 20, 2022
Merged

Add auth emulator#124
frasermcc9 merged 8 commits into701-T4:mainfrom
frasermcc9:framcc/auth-emulator

Conversation

@frasermcc9
Copy link
Copy Markdown
Contributor

@frasermcc9 frasermcc9 commented Mar 18, 2022

Description

Sets up the firebase auth emulator, which allows us to locally use auth services without effecting the prod auth service. Especially useful during tests so the service isn't spammed with random accounts.

Fixes/resolves #123

Should be merged before #94

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

Leave blank if not applicable

I have completed these steps when making this pull request:

  • I have assigned my name to the issue
  • I have moved the issue to the In Progress column
  • I have labelled the PR appropriately
  • I have assigned myself to the PR

Before opening the PR for review:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added attributions to new dependencies and resources
  • I have moved the linked issue to the Review in Progress column

@frasermcc9 frasermcc9 added front-end related to front-end code back-end related to back-end code dx related to developer experience labels Mar 18, 2022
@frasermcc9 frasermcc9 self-assigned this Mar 18, 2022
@frasermcc9 frasermcc9 requested review from a team as code owners March 18, 2022 11:29
@frasermcc9 frasermcc9 requested a review from a team as a code owner March 18, 2022 11:39
fishmonger45
fishmonger45 previously approved these changes Mar 19, 2022
Copy link
Copy Markdown
Contributor

@fishmonger45 fishmonger45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine when I have tried this locally, but my review should be cheapened my inexperience with this. All the new users were tracked in the auth UI fine

@frasermcc9
Copy link
Copy Markdown
Contributor Author

Everything works fine when I have tried this locally, but my review should be cheapened my inexperience with this

That probably makes it better since it worked with no extra setup :P

@fishmonger45
Copy link
Copy Markdown
Contributor

Maybe just add the emulator ui http://localhost:4000/auth to the appropriate readme? Probably not needed given it's a giant banner in stdout

fishmonger45
fishmonger45 previously approved these changes Mar 19, 2022
alyu201
alyu201 previously approved these changes Mar 19, 2022
@frasermcc9 frasermcc9 dismissed stale reviews from alyu201 and fishmonger45 via 5c03336 March 20, 2022 07:24
fishmonger45
fishmonger45 previously approved these changes Mar 20, 2022
fishmonger45
fishmonger45 previously approved these changes Mar 20, 2022
alyu201
alyu201 previously approved these changes Mar 20, 2022
@frasermcc9 frasermcc9 dismissed stale reviews from alyu201 and fishmonger45 via 7810997 March 20, 2022 07:34
Copy link
Copy Markdown
Contributor

@j-chad j-chad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@fishmonger45 fishmonger45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not many eggs left to break.

@frasermcc9 frasermcc9 merged commit 3ae0758 into 701-T4:main Mar 20, 2022
@frasermcc9 frasermcc9 deleted the framcc/auth-emulator branch March 20, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-end related to back-end code dx related to developer experience front-end related to front-end code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use auth emulator

4 participants