Add --enable-otel CLI flag for OpenTelemetry configuration

Cargo.toml

@@ -29,7 +29,7 @@ anyhow = { default-features = false, version = "1.0" }
 async-trait = { version = "0.1" }
 base64 = { version = "0.22" }
 chrono = { features = ["serde"], version = "0.4" }
-clap = { features = ["derive"], version = "4.5" }
+clap = { features = ["derive", "env"], version = "4.5" }
 deadpool = { default-features = false, features = ["managed", "rt_tokio_1"], version = "0.12" }
 deadpool-sync = { version = "0.1" }
 fs-err = { version = "3" }

bin/node/docker/docker-compose.yml

@@ -8,9 +8,9 @@ services:
       - "57292:57292"  # gRPC
       - "9091:9090"  # Health checks
     environment:
-      - OTEL_ENABLED=true
+      - MIDEN_TLNODE_ENABLE_OTEL=true
       - JSON_LOGGING=true
-      - OTEL_TRACES_ENDPOINT=http://otel-collector:4317
+      - MIDEN_TLNODE_OTEL_ENDPOINT=http://otel-collector:4317
       - OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf
       - OTEL_SERVICE_NAME=miden-note-transport-node
       - RUST_LOG=INFO

bin/node/src/main.rs

@@ -36,6 +36,18 @@ struct Args {
     /// Connection timeout in seconds
     #[arg(long, default_value = "4")]
     request_timeout: usize,
+
+    /// Enable OpenTelemetry tracing and metrics export
+    #[arg(long, env = "MIDEN_TLNODE_ENABLE_OTEL", default_value = "false")]
+    enable_otel: bool,
+
+    /// OpenTelemetry OTLP endpoint
+    #[arg(
+        long,
+        env = "MIDEN_TLNODE_OTEL_ENDPOINT",
+        default_value = "http://localhost:4317"
+    )]
+    otel_endpoint: String,
 }
 
 #[tokio::main]
@@ -44,7 +56,7 @@ async fn main() -> Result<()> {
     let args = Args::parse();
 
     // Setup tracing
-    let tracing_cfg = TracingConfig::from_env();
+    let tracing_cfg = TracingConfig::new(args.enable_otel, args.otel_endpoint.clone());
     setup_tracing(tracing_cfg.clone())?;
 
     info!("Starting Miden Transport Node...");

crates/node/src/logging.rs

@@ -33,22 +33,12 @@ pub enum OpenTelemetry {
 }
 
 impl TracingConfig {
-    /// Tracing configuration constructor using environment variables
-    pub fn from_env() -> Self {
-        let otel = {
-            let otel_enabled = std::env::var("OTEL_ENABLED")
-                .unwrap_or_else(|_| "false".to_string())
-                .parse()
-                .unwrap_or(false);
-            if otel_enabled {
-                OpenTelemetry::Enabled {
-                    endpoint: std::env::var("OTEL_TRACES_ENDPOINT")
-                        .ok()
-                        .unwrap_or("http://localhost:4317".to_string()),
-                }
-            } else {
-                OpenTelemetry::Disabled
-            }
+    /// Create a new tracing configuration with explicit parameters.
+    pub fn new(enable_otel: bool, otel_endpoint: String) -> Self {
+        let otel = if enable_otel {
+            OpenTelemetry::Enabled { endpoint: otel_endpoint }
+        } else {
+            OpenTelemetry::Disabled
         };
 
         TracingConfig {

deny.toml

@@ -43,7 +43,9 @@ allow = [
   "FTL",
   "ISC",
   "JSON",
+  "LGPL-3.0-or-later",
   "MIT",
+  "MPL-2.0",
   "MS-PL",
   "OpenSSL",
   "PostgreSQL",