Add --enable-otel CLI flag for OpenTelemetry configuration#80
Add --enable-otel CLI flag for OpenTelemetry configuration#80Dominik1999 wants to merge 2 commits intonextfrom
Conversation
- Add --enable-otel flag backed by MIDEN_TLNODE_ENABLE_OTEL env var - Add --otel-endpoint flag backed by MIDEN_TLNODE_OTEL_ENDPOINT env var - Enable clap "env" feature for env var backing - Replace TracingConfig::from_env() with explicit TracingConfig::new() - Update docker-compose env vars to match new naming Closes #40 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update rand 0.9.2 -> 0.9.4 to fix RUSTSEC-2026-0097 (unsoundness in ThreadRng reseeding with custom loggers) - Add MPL-2.0 and LGPL-3.0-or-later to deny.toml license allow list (required by pubgrub, version-ranges, priority-queue via upstream miden-assembly -> miden-package-registry) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WiktorStarczewski
left a comment
WiktorStarczewski
left a comment
There was a problem hiding this comment.
LGTM, just want to flag one thing, we have to be ok with LGPL-3-or-later in statically linked transitive deps in our published binaries. I think it's ok, but maybe worth a quick thought.
LGPL-3 static linking in Rust is legally ambiguous. The LGPL-3 "linking exception" was
▎ drafted around dynamic linking; Rust crates compile into the final binary as static
▎ linkage. Static-linking an LGPL-3 crate into a distributed binary (we publish to
▎ crates.io, and transport.miden.io is served from a Docker image built from this repo) can plausibly trigger LGPL-3 obligations — source provision alongside the distributed binary,
▎ license-notice inclusion in LICENSE / about screens, whatever else the license requires.
▎ There's no definitive Rust-community consensus on this; different projects land in
▎ different places (Mozilla's Servo forbids it, Bevy allows it, some crates explicitly
▎ re-license their static-linked LGPL deps).
|
Don't merge yet! We need to check LGPL-3 license compatibility with MIT |
3 participants
Summary
--enable-otelCLI flag backed byMIDEN_TLNODE_ENABLE_OTELenv var--otel-endpointCLI flag backed byMIDEN_TLNODE_OTEL_ENDPOINTenv varenvfeature for env var backingTracingConfig::from_env()with explicitTracingConfig::new()constructorTest plan
make testpasses (13/13)make lintpasses--helpshows new flags🤖 Generated with Claude Code
Closes #40