chore: migrate to protocol `v0.14.0-rc.1` by mmagician · Pull Request #1784 · 0xMiden/node

mmagician · 2026-03-11T19:44:50Z

Summary

Update all miden-protocol dependencies from 0.14.0-alpha.1 to 0.14.0-beta.1
Update miden-crypto from 0.19.7 to 0.22
Remove miden-air dependency
Bump node workspace version to 0.14.0-beta.1

Key API migrations

Serialization traits moved to utils::serde submodule
Felt::as_int() -> Felt::as_canonical_u64()
falcon512_rpo -> falcon512_poseidon2
ProvenTransactionBuilder removed, use ProvenTransaction::new() + TxAccountUpdate (refactor: remove ProvenTransactionBuilder in favor of ProvenTransaction::new protocol#2567)
OutputNote variants: Full -> Public, Header -> Private
Asset is now key-value (two words instead of one)
MmrProof fields are now methods
account_id_to_smt_key -> AccountIdKey::from()
SmtStorage trait methods now take &mut self
AccountStateForest rewritten to replace removed LargeSmtForest

Test plan

cargo check --all-targets passes
make lint passes (clippy, formatting, machete)
CI passes

🤖 Generated with Claude Code

Update all miden-protocol dependencies from 0.14.0-alpha.1 to 0.14.0-beta.1 (crates.io). Update miden-crypto from 0.19.7 to 0.22. Bump node workspace version to 0.14.0-beta.1. Key migration changes: - Serialization traits moved to utils::serde submodule - Felt::as_int() -> Felt::as_canonical_u64() - falcon512_rpo -> falcon512_poseidon2 - ProvenTransactionBuilder removed, use ProvenTransaction::new() - OutputNote variants: Full -> Public, Header -> Private - Asset is now key-value (two words instead of one) - MmrProof fields are now methods - account_id_to_smt_key -> AccountIdKey::from() - miden-air removed (replaced by miden-core 0.21) - SmtStorage trait methods now take &mut self - Various other API changes in miden-crypto 0.22

crates/large-smt-backend-rocksdb/src/lib.rs

mmagician · 2026-03-12T10:29:25Z

(force pushed coz I had unsigned commits)

crates/ntx-builder/src/actor/execute.rs

crates/validator/src/signers/kms.rs

- Use LargeSmt::load() instead of LargeSmt::new() in load_smt to support loading from non-empty RocksDB storage on restart (new() now errors with StorageNotEmpty in miden-crypto 0.22) - Fix prune logic to remove all versions before cutoff while keeping at least one version per lineage to preserve current state - Only pop roots from SmtForest that are no longer referenced by any lineage (prevents removing shared roots) - Fix test helpers tree_id_for_root/tree_id_for_vault_root to use get_root_at_block instead of latest_root - Update all prune test assertions for the new version-tracking model (our AccountStateForest uses explicit version entries rather than LargeSmtForest's deduplicated tree count)

Replace ~130 lines of hand-rolled DER parsing with proper library calls: - Use spki::SubjectPublicKeyInfoRef::from_der() for SPKI public key parsing - Use k256::ecdsa::Signature::from_der() for DER signature decoding This restores the simplicity of the original code before the migration, where PublicKey::from_der() and Signature::from_der() were available directly on the miden-crypto types.

Resolve conflicts in ntx-builder query tests by keeping test_utils imports and fixing TransactionId::new() signature for the beta API.

crates/block-producer/src/test_utils/note.rs

crates/large-smt-backend-rocksdb/src/rocksdb.rs

crates/rpc/src/tests.rs

crates/store/src/db/tests.rs

crates/block-producer/src/test_utils/proven_tx.rs

Remove stale comment about missing re-exports (fixed in miden-crypto 0.22.5) and import from miden_protocol::crypto::merkle::smt to match the convention used on next.

Public and private accounts were created with overlapping seed index ranges, which in the v0.14 beta can produce accounts with duplicate ID prefixes. Use separate non-overlapping index offsets for each storage mode within a block.

The previous approach used low-entropy seeds (index padded with zeros) which could produce AccountId prefix collisions during the hash grinding process. Use a seeded PRNG to generate full 32-byte random seeds per account while maintaining deterministic behavior.

Resolve conflict in state/loader.rs imports: keep RocksDbOptions from next's rocksdb config PR and AccountIdKey from our beta migration.

crates/remote-prover-client/src/remote_prover/batch_prover.rs

crates/remote-prover-client/src/remote_prover/tx_prover.rs

crates/remote-prover-client/src/remote_prover/block_prover.rs

crates/rpc/src/server/api.rs

mmagician · 2026-03-12T16:16:48Z

crates/rpc/src/server/api.rs

+            let rebuilt = PublicOutputNote::new(public_note.as_note().clone())
+                .expect("rebuilding an already-valid public output note should not fail");
+            OutputNote::Public(rebuilt)


this works but we might want to propagate minify_script to PublicOutputNote to avoid the reconstruction.

minify_script() is called in PublicOutputNote::new() - so, by construction all PublicOutputNotes have minified scripts. But maybe I didn't understand the comment?

Not quite: I was thinking of mutating PublicOutputNote, something like:

fn strip_output_note_decorators<'a>( notes: impl Iterator<Item = &'a OutputNote> + 'a, ) -> impl Iterator<Item = OutputNote> + 'a { notes.map(|note| match note { OutputNote::Public(public_note) => { let minified = public_note.clone().minify_script(); // <------ would need this OutputNote::Public(public_note) }, OutputNote::Private(header) => OutputNote::Private(header.clone()), }) }

so rather than fully reconstructing PublicOutputNote::new(), we would avoid some of the other checks that new constructor performs. These checks are not expensive at all, but I think it would also be cleaner to "only do the work necessary" to strip the decorators, using the constructor to do it feels somewhat hacky.

crates/store/src/account_state_forest/mod.rs

- Remove dead `Panic(JoinError)` variant from `NtxError` - Remove unused `get_root`/`set_root` and `ROOT_KEY` from `RocksDbStorage` - Replace verbose `std::iter::empty` with `Vec::new()` in rpc tests - Extract inline fee construction to `test_fee()` variable in store tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

crates/store/src/db/tests.rs

crates/validator/src/signers/kms.rs

- RpoRandomCoin renamed to RandomCoin - FungibleAssetDelta::iter() returns (&AssetVaultKey, &i64); extract faucet_id via vault_key.faucet_id() - Assets no longer impl Into<Word>; use to_value_word()/to_key_word() - TokenSymbol no longer Copy; clone where needed - AccountComponentMetadata::new() takes supported_types as second arg - AuthScheme::Falcon512Rpo -> Falcon512Poseidon2 - create_existing_agglayer_faucet() takes MetadataHash parameter Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Update bin/genesis for the rc.1 dep bump: - miden-agglayer: 0.14.0-beta.4 -> 0.14.0-rc.1 - RpoRandomCoin -> RandomCoin Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

crates/store/src/account_state_forest/mod.rs

crates/store/src/db/tests.rs

Co-authored-by: Claude (Opus) <noreply@anthropic.com>

crates/store/src/state/loader.rs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

mmagician

LGTM , I reviewed all the changes in detail

Mirko-von-Leipzig · 2026-03-24T11:23:51Z

bin/remote-prover/src/server/prover.rs

I thought proving was not going to be async? This isn't correct -- proving is synchronous work.

Mirko-von-Leipzig · 2026-03-24T11:25:05Z

bin/remote-prover/src/server/prover.rs

+        let result = self.prove(input).instrument(prove_span).await;
+
+        if let Err(e) = &result {
+            tracing::Span::current().set_error(e);


Suggested change

tracing::Span::current().set_error(e);

prove_span.set_error(e);

igamigo

LGTM!

igamigo · 2026-03-24T11:27:32Z

crates/store/src/account_state_forest/mod.rs

@@ -409,18 +409,20 @@ impl AccountStateForest {

        let mut entries: Vec<(Word, Word)> = Vec::new();


nit: Feels like this could be better typed (AssetVaultKey and, once it exists, AssetVaultAmount). May also improve the AccountStateForest API

igamigo · 2026-03-24T11:29:36Z

Cargo.toml

+
+[patch.crates-io]


nit:

Suggested change

[patch.crates-io]

Mirko-von-Leipzig · 2026-03-24T11:31:20Z

crates/store/src/state/loader.rs

                .commitments
                .into_iter()
-                .map(|(id, commitment)| (account_id_to_smt_key(id), commitment));
+                .map(|(id, commitment)| (AccountIdKey::from(id).as_word(), commitment));


Feels a bit weird that we're throwing away the type again

Mirko-von-Leipzig · 2026-03-24T11:32:26Z

Cargo.lock

Concerning that this is so much bigger

Mirko-von-Leipzig · 2026-03-24T11:34:00Z

crates/store/src/genesis/config/mod.rs

    fn from(symbol: TokenSymbol) -> Self {
        // SAFETY: TokenSymbol guarantees valid format, so to_string should not fail
-        let raw = symbol.to_string().expect("TokenSymbol should always produce valid string");
+        let raw = symbol.to_string();


SAFETY comment above should be removed

Mirko-von-Leipzig · 2026-03-24T11:37:13Z

bin/remote-prover/src/server/tests.rs

+            tokio::runtime::Handle::current()
+                .block_on(LocalTransactionProver::default().prove(tx.tx_inputs().clone()))
+                .unwrap()


I don't think this is allowed? Either way you should just use async since we now have that.

Mirko-von-Leipzig · 2026-03-24T11:40:39Z

crates/large-smt-backend-rocksdb/src/rocksdb.rs

            d => panic!("unsupported depth {d}"),
        };
-        KeyBytes::new(index.value(), keep)
+        KeyBytes::new(index.position(), keep)


Is this correct? value and position sound like opposites

Mirko-von-Leipzig · 2026-03-24T11:46:49Z

crates/rpc/src/server/api.rs

            tx.account_update().account_delta_commitment(),
+            tx.account_update().details().clone(),
+        )
+        .map_err(|e| Status::invalid_argument(e.to_string()))?;


e.to_string() is insufficient as it only surfaces the top level error

Mirko-von-Leipzig · 2026-03-24T11:47:10Z

crates/rpc/src/server/api.rs

-        let stripped_outputs = strip_output_note_decorators(tx.output_notes().iter());
-        builder = builder.add_output_notes(stripped_outputs);
-        let rebuilt_tx = builder.build().map_err(|e| Status::invalid_argument(e.to_string()))?;
+        .map_err(|e| Status::invalid_argument(e.to_string()))?;


Mirko-von-Leipzig

I've reviewed insofar as I am able. Not this PRs fault, but I ~~absolutely hate~~ dislike this :/ The churn and subtle changes are more than one can reasonably review and be confident in, in imo, and I wouldn't be surprised if this leads to a bunch of bugs that we'll only discover further down the line.

bobbinth · 2026-03-24T17:58:40Z

Cargo.toml

+miden-large-smt-backend-rocksdb = { path = "crates/large-smt-backend-rocksdb", version = "=0.14.0-beta.4" }
+miden-node-block-producer       = { path = "crates/block-producer", version = "=0.14.0-beta.4" }
+miden-node-db                   = { path = "crates/db", version = "=0.14.0-beta.4" }
+miden-node-grpc-error-macro     = { path = "crates/grpc-error-macro", version = "=0.14.0-beta.4" }
+miden-node-ntx-builder          = { path = "crates/ntx-builder", version = "=0.14.0-beta.4" }
+miden-node-proto                = { path = "crates/proto", version = "=0.14.0-beta.4" }
+miden-node-proto-build          = { path = "proto", version = "=0.14.0-beta.4" }
+miden-node-rpc                  = { path = "crates/rpc", version = "=0.14.0-beta.4" }
+miden-node-store                = { path = "crates/store", version = "=0.14.0-beta.4" }
 miden-node-test-macro           = { path = "crates/test-macro" }
-miden-node-utils                = { path = "crates/utils", version = "=0.14.0-alpha.8" }
-miden-node-validator            = { path = "crates/validator", version = "=0.14.0-alpha.8" }
-miden-remote-prover-client      = { path = "crates/remote-prover-client", version = "=0.14.0-alpha.8" }
+miden-node-utils                = { path = "crates/utils", version = "=0.14.0-beta.4" }
+miden-node-validator            = { path = "crates/validator", version = "=0.14.0-beta.4" }
+miden-remote-prover-client      = { path = "crates/remote-prover-client", version = "=0.14.0-beta.4" }
 # Temporary workaround until <https://github.com/rust-rocksdb/rust-rocksdb/pull/1029>
 # is part of `rocksdb-rust` release
-miden-node-rocksdb-cxx-linkage-fix = { path = "crates/rocksdb-cxx-linkage-fix", version = "=0.14.0-alpha.8" }


These could now be changed to just 0.14, right?

There's this other draft for that.

mmagician added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Mar 11, 2026

mmagician force-pushed the mmagician-claude/update-base-to-beta branch from b785bde to 922cd86 Compare March 11, 2026 19:46

mmagician changed the title ~~chore: migrate to protocol v0.14.0-beta.1~~ chore: migrate to protocol v0.14.0-beta.1 Mar 11, 2026

igamigo reviewed Mar 11, 2026

View reviewed changes

crates/large-smt-backend-rocksdb/src/lib.rs Outdated Show resolved Hide resolved

SantiagoPittella mentioned this pull request Mar 11, 2026

chore: use next from protocol #1785

Closed

igamigo and others added 4 commits March 11, 2026 17:12

chore: block_on

bc85d59

chore: patch crypto until a 0.22.x release is done

765169b

chore: update to crypto v0.22.5

44d5214

chore: fmt

5320e57

mmagician force-pushed the mmagician-claude/update-base-to-beta branch from bb9974c to 5320e57 Compare March 12, 2026 10:29

Merge branch 'next' into mmagician-claude/update-base-to-beta

4d53991

mmagician force-pushed the mmagician-claude/update-base-to-beta branch from 4c74ff6 to 4d53991 Compare March 12, 2026 10:32

SantiagoPittella mentioned this pull request Mar 12, 2026

Replace middle-step serialization of InputNoteCommitment with direct constructor #1783

Open

igamigo reviewed Mar 12, 2026

View reviewed changes

crates/ntx-builder/src/actor/execute.rs Outdated Show resolved Hide resolved

crates/validator/src/signers/kms.rs Show resolved Hide resolved

claude added 3 commits March 12, 2026 13:39

Merge branch 'next' into mmagician-claude/update-base-to-beta

a5f88db

Resolve conflicts in ntx-builder query tests by keeping test_utils imports and fixing TransactionId::new() signature for the beta API.

mmagician commented Mar 12, 2026

View reviewed changes

claude added 4 commits March 12, 2026 15:05

chore: import smt types from miden-protocol instead of miden-crypto

5767361

Remove stale comment about missing re-exports (fixed in miden-crypto 0.22.5) and import from miden_protocol::crypto::merkle::smt to match the convention used on next.

Merge branch 'next' into mmagician-claude/update-base-to-beta

71c29d4

Resolve conflict in state/loader.rs imports: keep RocksDbOptions from next's rocksdb config PR and AccountIdKey from our beta migration.

mmagician commented Mar 12, 2026

View reviewed changes

crates/store/src/account_state_forest/mod.rs Outdated Show resolved Hide resolved

claude and others added 2 commits March 12, 2026 16:55

chore: cleanup imports

0490027

mmagician commented Mar 12, 2026

View reviewed changes

crates/store/src/db/tests.rs Outdated Show resolved Hide resolved

sergerad reviewed Mar 12, 2026

View reviewed changes

crates/validator/src/signers/kms.rs Outdated Show resolved Hide resolved

claude added 2 commits March 23, 2026 10:55

fix: adapt genesis crate to rc.1 deps

269909a

Update bin/genesis for the rc.1 dep bump: - miden-agglayer: 0.14.0-beta.4 -> 0.14.0-rc.1 - RpoRandomCoin -> RandomCoin Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

mmagician force-pushed the mmagician-claude/update-base-to-beta branch from 070bcf7 to 269909a Compare March 23, 2026 10:55

mmagician changed the title ~~chore: migrate to protocol v0.14.0-beta.2~~ chore: migrate to protocol v0.14.0-rc.1 Mar 24, 2026

chore: use simpler FungibleAsset::from_key_value`

2450e4c

mmagician commented Mar 24, 2026

View reviewed changes

mmagician mentioned this pull request Mar 24, 2026

fix: restore test assertions weakened during LargeSmt revert #1830

Merged

2 tasks

mmagician and others added 3 commits March 24, 2026 10:40

fix: restore test assertions weakened during LargeSmt revert (#1830)

1f1f599

Co-authored-by: Claude (Opus) <noreply@anthropic.com>

revert: remove stress-test seeding offset changes (#1829)

44c1a68

Co-authored-by: Claude (Opus) <noreply@anthropic.com>

chore: no need to dup error strings, progagate

030a778

mmagician commented Mar 24, 2026

View reviewed changes

crates/store/src/state/loader.rs Outdated Show resolved Hide resolved

mmagician and others added 3 commits March 24, 2026 10:55

Merge branch 'next' into mmagician-claude/update-base-to-beta

e309055

fix: network transaction executor + network monitor (#1826)

0cc4066

fix: combine identical match arms to fix clippy lint

6ffd273

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

mmagician commented Mar 24, 2026

View reviewed changes

mmagician marked this pull request as ready for review March 24, 2026 11:11

mmagician requested a review from igamigo March 24, 2026 11:20

Mirko-von-Leipzig reviewed Mar 24, 2026

View reviewed changes

igamigo approved these changes Mar 24, 2026

View reviewed changes

Mirko-von-Leipzig reviewed Mar 24, 2026

View reviewed changes

Cargo.lock

Copy link

Collaborator

Mirko-von-Leipzig Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerning that this is so much bigger

Mirko-von-Leipzig reviewed Mar 24, 2026

View reviewed changes

greenhat mentioned this pull request Mar 24, 2026

chore: upgrade protocol to beta 0xMiden/miden-client#1891

Open

bobbinth reviewed Mar 24, 2026

View reviewed changes

	tracing::Span::current().set_error(e);
	prove_span.set_error(e);

		@@ -409,18 +409,20 @@ impl AccountStateForest {

		let mut entries: Vec<(Word, Word)> = Vec::new();

Conversation

mmagician commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key API migrations

Test plan

Uh oh!

Uh oh!

mmagician commented Mar 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmagician left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igamigo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mirko-von-Leipzig left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

mmagician commented Mar 11, 2026 •

edited

Loading

Mirko-von-Leipzig left a comment •

edited

Loading