fix: restore test assertions weakened during LargeSmt revert#1830
Merged
mmagician merged 1 commit intommagician-claude/update-base-to-betafrom Mar 24, 2026
Merged
Conversation
Reverts 5 test changes in db/tests.rs that were leftovers from the LargeSmt revert - they replaced concrete assertions with vague comments and unused variables. Also fixes clone_on_copy clippy lint. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
mmagician
added
the
no changelog
mmagician
merged commit 1f1f599
into
mmagician-claude/update-base-to-beta
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/store/src/db/tests.rsthat were weakened during the LargeSmt revert (concreteassert_eq!replaced withlet _and vague comments)clone_on_copyclippy lint inaccount_state_forest/mod.rs(vault_key.clone()->*vault_key)Addresses self-review comments on #1784.
Test plan
account_state_forest_shared_roots_not_deleted_prematurely,account_state_forest_retains_latest_after_100_blocks_and_pruning,account_state_forest_preserves_mixed_slots_independently🤖 Generated with Claude Code