feat(core): add stripped MastForest serialization #2549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
huitseeker/mastforest-deserialization
branch
from
4406e14 to
9492508
Compare
huitseeker
force-pushed
the
serialize-debuginfo-directly
branch
from
7c4a99e to
c88a02a
Compare
huitseeker
force-pushed
the
huitseeker/mastforest-deserialization
branch
from
9492508 to
9ddd236
Compare
huitseeker
force-pushed
the
serialize-debuginfo-directly
branch
from
c88a02a to
65a4972
Compare
huitseeker
force-pushed
the
huitseeker/mastforest-deserialization
branch
from
9ddd236 to
c47eabf
Compare
huitseeker
force-pushed
the
serialize-debuginfo-directly
branch
from
65a4972 to
7dc6b6e
Compare
huitseeker
force-pushed
the
huitseeker/mastforest-deserialization
branch
from
c47eabf to
4f4704c
Compare
Add support for serializing MastForest without debug information, producing smaller output files for production deployment. Changes: - Update header format: MAST (4 bytes) + FLAGS (1 byte) + VERSION (3 bytes) - Add FLAG_STRIPPED (0x01) to indicate debug info is omitted - Add MastForest::write_stripped() public method - Deserializer auto-detects format and creates empty DebugInfo when stripped - Reject unknown flags (reserved bits must be zero)
huitseeker
force-pushed
the
huitseeker/mastforest-deserialization
branch
from
4f4704c to
9f1e016
Compare
bobbinth
approved these changes
Jan 8, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks great! Thank you!
One thought for the future: stripping debug info removes most but not all debug-related info from the forest. Specifically, what is not removed are the inner values of Assert, U32assert2, and MpVerify operations. These contain error codes that probably are not super useful if we don't care about debugging.
There isn't a simple way to get rid of these though because operation serialization is handled pretty far deep in the stack.
Separately (and also not for this PR), I do think we should rename MastForest::strip_decorators() into something more like MastForest::clear_debug_info() because this method does more than just strip decorators.
Comment on lines
+137
to
+139
| // node & decorator counts | ||
| target.write_usize(self.nodes.len()); | ||
| // Expected to be used in #2504. Remove if this issue is resolved without using. | ||
| target.write_usize(self.debug_info.num_decorators()); | ||
| target.write_usize(if stripped { 0 } else { self.debug_info.num_decorators() }); |
Contributor
There was a problem hiding this comment.
Not for this PR, but I'm still not sure we need to serialize these values.
huitseeker
added a commit
that referenced
this pull request
Jan 8, 2026
huitseeker
added a commit
that referenced
this pull request
Jan 8, 2026
huitseeker
added a commit
that referenced
this pull request
Jan 8, 2026
huitseeker
added a commit
that referenced
this pull request
Jan 8, 2026
* refactor: rename strip_decorators to clear_debug_info The method clears the entire DebugInfo, not just decorators. * chore: Changelog * chore: fix CHANGELOG entries for #2549 and #2554 - Add method name `write_stripped()` to #2549 entry - Fix typo in #2554 entry: clear_debug_info (with underscore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2466 #2469 #2470. Adds support for serializing MastForest without debug information, producing smaller output files for production deployment.
FLAG_STRIPPED (0x01)to indicate debug info is omittedMastForest::write_stripped()public method, redirect to a proxy newtype (for type safety).DebugInfowhen strippedTogether with the above PRs this is stacked on, closes #1580.
Note: this complements rather than replaces the in-memory decorator stripping from #2108, which remains useful for improving execution and proving performance.