Skip to content

Conversation

@huitseeker
Copy link
Contributor

The method clears the entire DebugInfo, not just decorators.

@huitseeker huitseeker requested review from bobbinth and plafer January 8, 2026 10:29
@huitseeker huitseeker marked this pull request as ready for review January 8, 2026 11:18
CHANGELOG.md Outdated
- Change padded serialization of `BasicBlockNode`s to use delta-encoded metadata ([#2469](https://github.com/0xMiden/miden-vm/pull/2469/)).
- Change (de)serialization of `MastForest` to directly (de)serialize DebugInfo ([#2470](https://github.com/0xMiden/miden-vm/pull/2470/)).
- Add API to serialize the `MastForest` without `DebugInfo` ([#2549](https://github.com/0xMiden/miden-vm/pull/2549)).
- [BREAKING] rename MastForest::strip_decorators -> MastForest::clear_debuginfo ([#2554](https://github.com/0xMiden/miden-vm/pull/2554)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this PR is really an extension of #2549, and that the previous changelog entry is vague about what the API to serialize the MastForest without DebugInfo is, I don't think we need a changelog entry for this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You make a good point, let me fix the vagueness of the prior entry.

huitseeker added a commit that referenced this pull request Jan 8, 2026
- Add method name `write_stripped()` to #2549 entry
- Fix typo in #2554 entry: clear_debug_info (with underscore)
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

huitseeker added a commit that referenced this pull request Jan 8, 2026
- Add method name `write_stripped()` to #2549 entry
- Fix typo in #2554 entry: clear_debug_info (with underscore)
@huitseeker huitseeker force-pushed the huitseeker/rename-strip-decorators-to-clear-debug-info branch from 896a2a5 to e969cf4 Compare January 8, 2026 18:00
The method clears the entire DebugInfo, not just decorators.
- Add method name `write_stripped()` to #2549 entry
- Fix typo in #2554 entry: clear_debug_info (with underscore)
@huitseeker huitseeker force-pushed the huitseeker/rename-strip-decorators-to-clear-debug-info branch from e969cf4 to 145caa1 Compare January 8, 2026 18:34
@huitseeker huitseeker merged commit 889140f into next Jan 8, 2026
16 checks passed
@huitseeker huitseeker deleted the huitseeker/rename-strip-decorators-to-clear-debug-info branch January 8, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants