-
Notifications
You must be signed in to change notification settings - Fork 250
refactor: rename strip_decorators to clear_debug_info #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename strip_decorators to clear_debug_info #2554
Conversation
CHANGELOG.md
Outdated
| - Change padded serialization of `BasicBlockNode`s to use delta-encoded metadata ([#2469](https://github.com/0xMiden/miden-vm/pull/2469/)). | ||
| - Change (de)serialization of `MastForest` to directly (de)serialize DebugInfo ([#2470](https://github.com/0xMiden/miden-vm/pull/2470/)). | ||
| - Add API to serialize the `MastForest` without `DebugInfo` ([#2549](https://github.com/0xMiden/miden-vm/pull/2549)). | ||
| - [BREAKING] rename MastForest::strip_decorators -> MastForest::clear_debuginfo ([#2554](https://github.com/0xMiden/miden-vm/pull/2554)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this PR is really an extension of #2549, and that the previous changelog entry is vague about what the API to serialize the MastForest without DebugInfo is, I don't think we need a changelog entry for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You make a good point, let me fix the vagueness of the prior entry.
bobbinth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
896a2a5 to
e969cf4
Compare
The method clears the entire DebugInfo, not just decorators.
e969cf4 to
145caa1
Compare
The method clears the entire DebugInfo, not just decorators.