Skip to content

ci: fix cargo publish workflow #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huitseeker wants to merge 3 commits into from
Closed

ci: fix cargo publish workflow #2505

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b2e615
fix(test-serde-macros): remove non-existent README reference
huitseeker Dec 30, 2025
f5bc8a8
fix(workspace): enable default features for miden-utils-sync
huitseeker Dec 30, 2025
4458e5e
Merge branch 'next' into huitseeker/publish-workflow
bobbinth Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ miden-core-lib = { path = "./crates/lib/core", version = "0.21", default-feature
miden-utils-core-derive = { path = "./crates/utils-core-derive", version = "0.21", default-features = false }
miden-utils-diagnostics = { path = "./crates/utils-diagnostics", version = "0.21", default-features = false }
miden-utils-indexing = { path = "./crates/utils-indexing", version = "0.21", default-features = false }
miden-utils-sync = { path = "./crates/utils-sync", version = "0.21", default-features = false }
miden-utils-sync = { path = "./crates/utils-sync", version = "0.21" }
Copy link
Contributor

@bobbinth bobbinth Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that appeared recently? IIRC, we published v0.20 VM with default features turned off for miden-utils-sync.

Copy link
Contributor Author

@huitseeker huitseeker Dec 30, 2025 •
edited by bobbinth
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change establishing std for miden-utils-sync is from the late innings of #2447.

Copy link
Contributor

@bobbinth bobbinth Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure I understand why this is happening. AFAICT, OnceLockCompat is exported from miden-utils-sync both in std and in no_std context (in no_std we export the wrapper around OnceBox). So, even with default-features = false it should work - no?

Copy link
Contributor Author

@huitseeker huitseeker Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is not reproducible for me locally. My hypothesis is that in CI, the dry-run :

  • Packages each crate independently
  • Verifies each package in isolation using a temporary registry
  • This isolated verification context appears to have different feature resolution behavior than normal workspace builds.

Nonetheless, out of an abundance of caution, I'll close this.

miden-utils-testing = { path = "./crates/test-utils", package = "miden-test-utils" }
miden-verifier = { path = "./verifier", version = "0.21", default-features = false }

Expand Down
1 change: 0 additions & 1 deletion crates/test-serde-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
name = "miden-test-serde-macros"
version = "0.1.0"
description = "Proc macros for serde roundtrip testing in Miden VM"
readme = "README.md"
categories = ["development-tools::testing", "no-std"]
keywords = ["miden", "serde", "testing", "proc-macro"]
publish = false
Expand Down
Loading