ci: fix cargo publish workflow #2505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove readme field from Cargo.toml since the file doesn't exist and the crate is not published (publish = false).
When miden-utils-sync is declared with default-features = false in the workspace dependencies, cargo publish verification builds dependent crates without the std feature, causing OnceLockCompat to not be available. This fixes the CI failure where miden-core couldn't find OnceLockCompat during package verification.
huitseeker
added
the
no changelog
bobbinth
reviewed
Dec 30, 2025
| miden-utils-diagnostics = { path = "./crates/utils-diagnostics", version = "0.21", default-features = false } | ||
| miden-utils-indexing = { path = "./crates/utils-indexing", version = "0.21", default-features = false } | ||
| miden-utils-sync = { path = "./crates/utils-sync", version = "0.21", default-features = false } | ||
| miden-utils-sync = { path = "./crates/utils-sync", version = "0.21" } |
Contributor
There was a problem hiding this comment.
Is this something that appeared recently? IIRC, we published v0.20 VM with default features turned off for miden-utils-sync.
Contributor
Author
There was a problem hiding this comment.
The change establishing std for miden-utils-sync is from the late innings of #2447.
Contributor
There was a problem hiding this comment.
I'm still not sure I understand why this is happening. AFAICT, OnceLockCompat is exported from miden-utils-sync both in std and in no_std context (in no_std we export the wrapper around OnceBox). So, even with default-features = false it should work - no?
Contributor
Author
There was a problem hiding this comment.
Yep, this is not reproducible for me locally. My hypothesis is that in CI, the dry-run :
- Packages each crate independently
- Verifies each package in isolation using a temporary registry
- This isolated verification context appears to have different feature resolution behavior than normal workspace builds.
Nonetheless, out of an abundance of caution, I'll close this.
huitseeker
force-pushed
the
huitseeker/publish-workflow
branch
2 times, most recently
from
567257b to
4458e5e
Compare
huitseeker
added a commit
that referenced
this pull request
Jan 4, 2026
The workspace publish dry-run fails with `unresolved import
miden_utils_sync::OnceLockCompat` during verification. This happens
because cached registry data from previous CI runs can interfere with
cargo's temp registry used for workspace dependency resolution.
During verification, cargo should use the packaged v0.21.0 from the
temp registry, but stale cache entries may cause it to resolve
against crates.io data instead (where v0.20.1 lacks OnceLockCompat).
Clear ~/.cargo/registry/{cache,index,src} before the dry-run to ensure
fresh resolution without interference from cached data.
Closes #2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8e1833 is failing its
cargo publish --dry-run --workspacebecause of a menial time-of-pr versus time-of-merge issue. See commit messages.