feat: Integrate RPC with Validator for transaction validation #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergerad
commented
Dec 16, 2025
10 tasks
sergerad
requested review from
Mirko-von-Leipzig,
PhilippGackstatter and
bobbinth
bobbinth
reviewed
Dec 16, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left some comments inline - but they are pretty minor.
bobbinth
approved these changes
Dec 16, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of optional comments inline.
| pub async fn validate_transaction( | ||
| proven_tx: ProvenTransaction, | ||
| tx_inputs: TransactionInputs, | ||
| ) -> Result<(), TransactionValidationError> { |
Contributor
There was a problem hiding this comment.
Returning () is fine for now, but I do think that we'll probably end up returning TransactionHeader from here so that we can store it in the validator's database.
PhilippGackstatter
approved these changes
Dec 17, 2025
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
I reviewed only the CodeBuilder parts. Those LGTM.
| .unwrap() | ||
| .with_supported_type(AccountType::RegularAccountImmutableCode); | ||
| let account_component_code = CodeBuilder::default() | ||
| .compile_component_code("baz::interface", "export.baz push.3 end") |
Contributor
There was a problem hiding this comment.
FYI: After 0xMiden/miden-base#2158 is merged, all exports will have to become pub proc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The RPC still performs transaction validation from a module in its server crate. Instead, it needs to use the Validator client to allow the Validator component to perform the transaction validation.
Relates to #1316.
Changes
Note: most of the changes are miscellaneous fixes to bring node up to date with miden-base