chore: unify Makefile build and clippy into single cargo invocations#1948
Merged
juan518munoz merged 1 commit intonextfrom Mar 31, 2026
Merged
chore: unify Makefile build and clippy into single cargo invocations#1948juan518munoz merged 1 commit intonextfrom
juan518munoz merged 1 commit intonextfrom
Conversation
juan518munoz
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildandclippytargets splittesting-remote-proverinto a separatecargocommand because it used a differentmiden-txversion. That's no longer the case, there's a single version inCargo.lock, so everything can run in one invocation.Running separate commands causes cargo to re-resolve features between invocations, invalidating cached artifacts and recompiling shared dependencies. Of 503 unique crates, 116 get compiled twice and 45 get compiled three times, adding 206 redundant compilations (116 + 45*2).
Benchmarks (M4 Max, same commit, sequential,
cargo cleanbefore each):