Skip to content

chore: unify Makefile build and clippy into single cargo invocations#1948

Merged
juan518munoz merged 1 commit intonextfrom
jere/unify-makefile-build
Mar 31, 2026
Merged

chore: unify Makefile build and clippy into single cargo invocations#1948
juan518munoz merged 1 commit intonextfrom
jere/unify-makefile-build

Conversation

@JereSalo
Copy link
Copy Markdown
Collaborator

@JereSalo JereSalo commented Mar 30, 2026

The build and clippy targets split testing-remote-prover into a separate cargo command because it used a different miden-tx version. That's no longer the case, there's a single version in Cargo.lock, so everything can run in one invocation.

Running separate commands causes cargo to re-resolve features between invocations, invalidating cached artifacts and recompiling shared dependencies. Of 503 unique crates, 116 get compiled twice and 45 get compiled three times, adding 206 redundant compilations (116 + 45*2).

Benchmarks (M4 Max, same commit, sequential, cargo clean before each):

Before (3 commands) After (1 command) Improvement
Total compilations 709 503 -29%
Redundant compilations 206 0 -100%
Wall time 4m 14s 2m 50s -33%

@JereSalo JereSalo added no changelog This PR does not require an entry in the `CHANGELOG.md` file maintainer PRs that come from internal contributors or integration partners. They should be given priority. labels Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think I had pushed a similar change to #1891

@JereSalo JereSalo marked this pull request as ready for review March 31, 2026 11:40
@juan518munoz juan518munoz merged commit 8fd7678 into next Mar 31, 2026
38 checks passed
@juan518munoz juan518munoz deleted the jere/unify-makefile-build branch March 31, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer PRs that come from internal contributors or integration partners. They should be given priority. no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants