feat: update public account retrieval #1591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic-account-retrieval
fkrause98
requested review from
SantiagoPittella and
igamigo
and removed request for
igamigo
fkrause98
added
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: #1563.
There's a (currently open) PR for miden-node that unifies the "GetAccountDetails" and "GetAccountProofs endpoints" into a single endpoint "GetAccount". The goal of this PR is to adapt to said new endpoint, while preserving the actual NodeRpcClient trait API.
We will probably have to wait for said PR to be merged to be merged. Since I've encountered some versioning issues while working with this, so I'm currently using a local setup for this to work.
Also, something important is that the new protobuf structures have changed quite a bit, so there are probably some
parameters I might've missed or that we should decide on how to handle them.
Tasks Left: