Skip to content

Conversation

@fkrause98
Copy link
Contributor

@fkrause98 fkrause98 commented Dec 15, 2025

Description

While testing the new public account retrieval flow in the miden-client, we stumbled upon an error when requesting details of a network account.

This PR simply changes the check to allow the retrieval of details for public and network accounts.

@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Dec 15, 2025
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit dd1446a into 0xMiden:next Dec 15, 2025
16 of 17 checks passed
@Mirko-von-Leipzig
Copy link
Collaborator

Mirko-von-Leipzig commented Dec 22, 2025

Just to understand this properly. Is the problem that Account::is_public() returns false for network accounts? And this is because it is short-hand for something like

enum AccountType {
    Private,
    Public,
    Network,
}

fn is_public(self: &AccountType) -> bool {
    matches!(self, AccountType::Public)
}

We really need to work on our naming schemes if that's the case. Or remove these helpers.

@igamigo
Copy link
Collaborator

igamigo commented Dec 22, 2025

Just to understand this properly. Is the problem that Account::is_public() returns false for network accounts?

Yeah, this was pretty much it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants