refactor: move Address module from miden-protocol to miden-standards

CHANGELOG.md

@@ -27,7 +27,7 @@
 - [BREAKING] Renamed `AccountProcedureInfo` into `AccountProcedureRoot` and remove storage offset and size ([#2162](https://github.com/0xMiden/miden-base/pull/2162)).
 - [BREAKING] Made `AccountProcedureIndexMap` construction infallible ([#2163](https://github.com/0xMiden/miden-base/pull/2163)).
 - [BREAKING] Renamed `tracked_procedure_roots_slot` to `trigger_procedure_roots_slot` in ACL auth components for naming consistency ([#2166](https://github.com/0xMiden/miden-base/pull/2166)).
-- [BREAKING] Refactor `miden-objects` and `miden-lib` into `miden-protocol` and `miden-standards` ([#2184](https://github.com/0xMiden/miden-base/pull/2184), [#2191](https://github.com/0xMiden/miden-base/pull/2191), [#2197](https://github.com/0xMiden/miden-base/pull/2197)).
+- [BREAKING] Refactor `miden-objects` and `miden-lib` into `miden-protocol` and `miden-standards` ([#2184](https://github.com/0xMiden/miden-base/pull/2184), [#2191](https://github.com/0xMiden/miden-base/pull/2191), [#2197](https://github.com/0xMiden/miden-base/pull/2197), [#2255](https://github.com/0xMiden/miden-base/pull/2255)).
 - [BREAKING] Migrated to `miden-vm` v0.20 and `miden-crypto` v0.19 ([#2158](https://github.com/0xMiden/miden-base/pull/2158)).
 - [BREAKING] Refactored `AccountStorageDelta` to use a new `StorageSlotDelta` type ([#2182](https://github.com/0xMiden/miden-base/pull/2182)).
 - [BREAKING] Removed OLD_MAP_ROOT from being returned when calling [`native_account::set_map_item`](crates/miden-lib/asm/miden/native_account.masm) ([#2194](https://github.com/0xMiden/miden-base/pull/2194)).

crates/miden-protocol/src/account/account_id/mod.rs

@@ -16,7 +16,6 @@ mod id_version;
 use alloc::string::{String, ToString};
 use core::fmt;
 
-use bech32::primitives::decode::ByteIter;
 pub use id_version::AccountIdVersion;
 use miden_core::Felt;
 use miden_core::utils::{ByteReader, Deserializable, Serializable};
@@ -341,7 +340,9 @@ impl AccountId {
     }
 
     /// Decodes the data from the bech32 byte iterator into an [`AccountId`].
-    pub(crate) fn from_bech32_byte_iter(byte_iter: ByteIter<'_>) -> Result<Self, AccountIdError> {
+    pub fn from_bech32_byte_iter(
+        byte_iter: impl Iterator<Item = u8>,
+    ) -> Result<Self, AccountIdError> {
         AccountIdV0::from_bech32_byte_iter(byte_iter).map(AccountId::V0)
     }
 

crates/miden-protocol/src/account/account_id/v0/mod.rs

@@ -5,7 +5,7 @@ use core::fmt;
 use core::hash::Hash;
 
 use bech32::Bech32m;
-use bech32::primitives::decode::{ByteIter, CheckedHrpstring};
+use bech32::primitives::decode::CheckedHrpstring;
 use miden_crypto::utils::hex_to_bytes;
 pub use prefix::AccountIdPrefixV0;
 
@@ -272,21 +272,23 @@ impl AccountIdV0 {
     }
 
     /// Decodes the data from the bech32 byte iterator into an [`AccountId`].
-    pub(crate) fn from_bech32_byte_iter(byte_iter: ByteIter<'_>) -> Result<Self, AccountIdError> {
-        // The _remaining_ length of the iterator must be the serialized size of the account ID.
-        if byte_iter.len() != Self::SERIALIZED_SIZE {
+    pub(crate) fn from_bech32_byte_iter(
+        byte_iter: impl Iterator<Item = u8>,
+    ) -> Result<Self, AccountIdError> {
+        // Collect the iterator into a Vec to check length and iterate
+        let bytes: Vec<u8> = byte_iter.collect();
+
+        // The length must be the serialized size of the account ID.
+        if bytes.len() != Self::SERIALIZED_SIZE {
             return Err(AccountIdError::Bech32DecodeError(Bech32Error::InvalidDataLength {
                 expected: Self::SERIALIZED_SIZE,
-                actual: byte_iter.len(),
+                actual: bytes.len(),
             }));
         }
 
-        // Every byte is guaranteed to be overwritten since we've checked the length of the
-        // iterator.
+        // Convert Vec to array
         let mut id_bytes = [0_u8; Self::SERIALIZED_SIZE];
-        for (i, byte) in byte_iter.enumerate() {
-            id_bytes[i] = byte;
-        }
+        id_bytes.copy_from_slice(&bytes);
 
         let account_id = Self::try_from(id_bytes)?;