refactor: move Address module from miden-protocol to miden-standards #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the Address struct and its associated methods for managing user-facing addresses in the Miden protocol, including encoding and decoding functionalities.
Implement AddressId enum with methods for address type, default note tag length, byte representation, and bech32 decoding.
Implement AddressInterface enum with basic wallet variant and conversion methods.
Updated visibility of from_hrp and into_hrp methods to public for usage in miden-standards, while adding cautionary notes regarding bech32 types.
Refactor from_bech32_byte_iter to use an iterator and collect bytes.
Update comments to reflect changes in re-exports.
Contributor
|
@CreeptoGengar Thank you for the PR. Could you also add an entry in CHANGELOG.md to make CI happy? Could you also rebase this on the latest next? Note that |
* feat: move standard note scripts into standard library Move note script logic from standalone files in `note_scripts/` directory to `miden::standards::notes` namespace modules. This enables dynamic access to script roots via `procref` instead of hardcoding values. Changes: - Add new modules under `standards/notes/`: p2id, p2ide, swap, burn, mint - Each module contains a `pub proc main` with the script logic - Original note script files now serve as minimal wrappers calling `exec.<note>::main` Closes 0xMiden#2243 * chore: add changelog entry for note scripts refactoring * docs: fix namespace references in note script documentation * chore: update docs contracts->standards --------- Co-authored-by: Marti <[email protected]>
CreeptoGengar
force-pushed
the
move-address-to-standarts
branch
from
318984a to
1919279
Compare
Contributor
|
@CreeptoGengar - we've merged some work into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Address module from
miden-protocoltomiden-standardsas per #2214.Changes:
Address,AddressId,AddressInterface, andRoutingParameterstomiden-standardsAddressTypeandNetworkIdinmiden-protocol(used internally)AddressId::decodeto useimpl Iterator<Item = u8>instead ofByteIterAccountId::from_bech32_byte_iterpublic and acceptsimpl Iterator<Item = u8>NoteTag::from_network_account_idandfrom_local_account_idpublic