-
Notifications
You must be signed in to change notification settings - Fork 106
Migrate docs to docusaurus #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dominik1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it looks good. I left 3 small comments. I have built it locally and looked mostly on the layout.
|
|
||
| > [!Note] | ||
| > A collection of [assets](../asset.md) stored by the `Account`. | ||
| :::note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it looks weird now with how Docusaurus renders those :::note tags in comparison to the mdbook render.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to add that change as part of the "overhaul" that you mentioned down below, what do you think?
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I mainly looked through the docs and they render very nicely 🎉.
Left a few comments, but mostly small things or questions. Feel free to address what you think makes sense.
bobbinth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've browsed through the new docs locally, and they look really good!
This is not a full review yet, but a few quesitons/comments:
- We probably should update the
Makefileas there are some mdBook specific commands there (e.g.,book,check-toolsandinstall-tools). - Related to the above, should we add a command to the
Makefileto serve the docs? (i.e., similar to the currentbookcommand). - We should probably also document somewhere that we need to install NPM for this to work. Maybe somewhere in the main
README? We could also add NPM installation to theinstall-toolscommand, but not sure how difficult this would be. - Do we want to have a CI job to make sure there are no build issues with the docs? Or would this be handled by the "deploy docs" workflow?
- What would we need to do to also deploy these docs locally? Similar to how we currently deploy the mdBook docs as a Github page at https://0xmiden.github.io/miden-base
- I know one of the reasons we are moving to Docusaurus is to be able to show multiple doc versions. Would we also be able to do it locally? (i.e, would be awesome to have docs for
mainvs.next). Not something for this PR - but just curious if it'll work in the future.
- I know one of the reasons we are moving to Docusaurus is to be able to show multiple doc versions. Would we also be able to do it locally? (i.e, would be awesome to have docs for
bobbinth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! Though, I primarily reviewed the high-level structure.
One thing: it would be great to add a brief comment in the trigger-deploy-docs.yml file explaining what it does. My understanding is that on every merge to next, it would trigger a rebuild of the docs in the miden-docs repo, which in turn would pull the latest docs from next branches of all relevant docs. But maybe I'm missing some detail.
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for the additional comments and explainers and migrating to YAML - much appreciated!
This comment was marked as resolved.
This comment was marked as resolved.
|
|
||
| steps: | ||
| - name: Send repository_dispatch to aggregator | ||
| uses: peter-evans/repository-dispatch@a628c95fd17070f003ea24579a56e6bc89b25766 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why use a specific commit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to a comment from Paul on the compiler docs PR: 0xMiden/compiler#692 (comment)
In essence we want to use specific SHA revision because of security considerations. The workflow's are using PATs, which have certain permissions and w do not necessarily want to just rely on tags, which could be overridden by a potentially unsafe ref.
e904997 to
722bf61
Compare
- Migrated documentation from mdbook to docusaurus - Updated protocol_library.md with detailed formatting and resolved merge conflicts - Added proper markdown links and structure - Incorporated new procedures from next branch - Added build and deployment workflows for docs
722bf61 to
289c2b3
Compare
22680da to
e476e35
Compare

Summary
This PR migrates the existing documentation from mdbook to Docusaurus. This includes syntax changes and structural updates.
🚨 DO NOT MERGE YET 🚨
Merging this PR before all other Docusaurus PRs are ready will break the docs deployment! Also, merging has to be done in correct order to ensure a smooth transition!
Note
docs/src.Changes
Syntax changes
As already mentioned before, this PR changes the markdown syntax of all docs markdown files.
Going forward all documentation will also be written using Docusaurus sytnax.
NOTE: Please review the updated Markdown files to understand the new format.
Local testing
To test docs locally before pushing changes:
cd docsNote: The
index.mdfile might not appear in the correct sidebar order during local dev. In production deployments it will. To guarantee proper ordering, ensureindex.mdincludes:New Docs Architecture
The documentation system no longer relies on cron jobs or local scripts. Instead, changes are propagated through a CI-driven process. Here are the key changes:
Instead of relying on a cron task to update the docs, every repository now integrates a "trigger-docs-deploy.yml" workflow, which automatically triggers a rebuild and redeployment of the docs upon changes to
next.Upon Testnet deployments, a dedicated workflow inside of the miden-docs repository can be triggered to create a snapshot of the docs for that specific version. This workflow has to be triggered manually.