-
Notifications
You must be signed in to change notification settings - Fork 2
docs: add documentation in docusaurus format #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
671733d to
1a50bca
Compare
.github/workflows/book.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this for now - our documentation is going to be done via Docusaurus going forward, so I don't think it makes sense to build them as mdbook docs at this point:
/cc @Keinberger
bitwalker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @Keinberger do a review here, and I'll defer to him on the structure/config of the docs so that it meshes with our overall documentation system and strategy.
Keinberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lima-limon-inc , thanks for opening up this PR to add documentation to midenup!
We are currently in the phase of migrating all our documentation from mdbook to Docusaurus.
Henceforth we need to change this PR to be in line with that and implement a local Docusaurus environment instead of using mdbook.
Please take a look at the code of this PR and its respective files: 0xMiden/miden-base#1943
Things to take a look at:
- Everything inside of
docs/directory (for Docusaurus project structure and Docusaurus md syntax) - .github/workflows (those have to be added for the midenup docs too)
trigger-deploy-docs.yml: This workflow has to be added to trigger a rebuild & redeployment of the docs whenever changes occurbuild-docs.yml: This workflow builds the docsupon changes and serves to catch bugs, syntax and linting errors in the docs
After that, please amend this current PR so that it implements a Docusaurus docs project in line with the PR code that I just shared. That way, it can be integrated into the general structure/config of our Miden Docs.
I did not review the content of the markdown files yet, as there might be changes due to the Docusaurus migration. I will do that once the PR has been migrated to Docusaurus, let me know once it’s ready! :) Thanks!
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
1a50bca to
43bcd69
Compare
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
|
Hi @Keinberger, I have migrated the docs from mdbook to docusaurus. Besides that change, I also re-wrote some of the documentation I had written, just so that it was clear enough. When you have the time, would you mind giving this a review? Thanks in advance! Let me know your thoughts 😊 |
|
Was trying to make a couple of edits to the docs (formatting, styling, etc...) but I can't since I do not have permission to make commits on this repo. Would either one of you @lima-limon-inc @bitwalker mind adding me as a contributor here? |
|
Hey @lima-limon-inc , here's my review:
Before merging, I have a couple of asks for you:
|
Done |
|
Hey there @Keinberger. Thank you for the feedback. I'll be addressing your comments now! |
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
|
Hi @Keinberger, I have updated both Mainly, I used the "profile" config files for the shells instead of the "rc" files. If I'm not mistaken, if an Let me know what you think! |
|
@Keinberger can you let me know if this can be merged? |
Closes #98
Besides adding a tutorial, this PR also includes:
midenup