Skip to content

Conversation

@lima-limon-inc
Copy link
Collaborator

@lima-limon-inc lima-limon-inc commented Sep 24, 2025

Closes #98

Besides adding a tutorial, this PR also includes:

  • A "getting started" page, which documents how to use midenup
  • A "design" page explaining some aspects of midenup's implementation

@lima-limon-inc lima-limon-inc self-assigned this Sep 24, 2025
@lima-limon-inc lima-limon-inc force-pushed the fabriziooris/i98-tutorial branch from 671733d to 1a50bca Compare October 6, 2025 23:40
@lima-limon-inc lima-limon-inc marked this pull request as ready for review October 6, 2025 23:45
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this for now - our documentation is going to be done via Docusaurus going forward, so I don't think it makes sense to build them as mdbook docs at this point:

/cc @Keinberger

Copy link
Collaborator

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @Keinberger do a review here, and I'll defer to him on the structure/config of the docs so that it meshes with our overall documentation system and strategy.

Copy link
Collaborator

@Keinberger Keinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lima-limon-inc , thanks for opening up this PR to add documentation to midenup!

We are currently in the phase of migrating all our documentation from mdbook to Docusaurus.

Henceforth we need to change this PR to be in line with that and implement a local Docusaurus environment instead of using mdbook.

Please take a look at the code of this PR and its respective files: 0xMiden/miden-base#1943

Things to take a look at:

  • Everything inside of docs/ directory (for Docusaurus project structure and Docusaurus md syntax)
  • .github/workflows (those have to be added for the midenup docs too)
    • trigger-deploy-docs.yml: This workflow has to be added to trigger a rebuild & redeployment of the docs whenever changes occur
    • build-docs.yml: This workflow builds the docsupon changes and serves to catch bugs, syntax and linting errors in the docs

After that, please amend this current PR so that it implements a Docusaurus docs project in line with the PR code that I just shared. That way, it can be integrated into the general structure/config of our Miden Docs.

I did not review the content of the markdown files yet, as there might be changes due to the Docusaurus migration. I will do that once the PR has been migrated to Docusaurus, let me know once it’s ready! :) Thanks!

@lima-limon-inc lima-limon-inc marked this pull request as draft October 28, 2025 13:38
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
@lima-limon-inc lima-limon-inc force-pushed the fabriziooris/i98-tutorial branch from 1a50bca to 43bcd69 Compare October 31, 2025 21:21
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
@lima-limon-inc lima-limon-inc marked this pull request as ready for review November 3, 2025 19:28
@lima-limon-inc
Copy link
Collaborator Author

Hi @Keinberger, I have migrated the docs from mdbook to docusaurus. Besides that change, I also re-wrote some of the documentation I had written, just so that it was clear enough.

When you have the time, would you mind giving this a review? Thanks in advance!

Let me know your thoughts 😊

@lima-limon-inc lima-limon-inc changed the title docs: add TUTORIAL.md docs: add documentation in docusaurus format Nov 3, 2025
@Keinberger
Copy link
Collaborator

Was trying to make a couple of edits to the docs (formatting, styling, etc...) but I can't since I do not have permission to make commits on this repo. Would either one of you @lima-limon-inc @bitwalker mind adding me as a contributor here?

@Keinberger
Copy link
Collaborator

Hey @lima-limon-inc , here's my review:

  • I updated the stylesheet, added a needed override for a Docusaurus theme component (for styling) and also fixed the fomratting in the md files so that the spacing is correctly reflected on the render. For me to push those changes though, please add me as a contributor to this repo.
  • Content wise I think this is good to go!

Before merging, I have a couple of asks for you:

@bitwalker
Copy link
Collaborator

Was trying to make a couple of edits to the docs (formatting, styling, etc...) but I can't since I do not have permission to make commits on this repo. Would either one of you @lima-limon-inc @bitwalker mind adding me as a contributor here?

Done

@lima-limon-inc
Copy link
Collaborator Author

lima-limon-inc commented Nov 7, 2025

Hey there @Keinberger. Thank you for the feedback.

I'll be addressing your comments now!

Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
@lima-limon-inc
Copy link
Collaborator Author

Hi @Keinberger, I have updated both installation.md and tutorial.md. I made some slight changes with respect to your docs in https://github.com/0xMiden/miden-docs/blob/623381639ab54f45ca2d2eca0e5fae5875d9eb20/docs/quick-start/index.md.

Mainly, I used the "profile" config files for the shells instead of the "rc" files. If I'm not mistaken, if an export command is present on an rc file, the PATH environment variable will be re-defined every time a shell is opened.
Additionally, I removed the initialization commands from the tutorial page since now it gets auto initialized.

Let me know what you think!

@bitwalker
Copy link
Collaborator

@Keinberger can you let me know if this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: add a midenup tutorial

4 participants