[6/x] Add traced execution option on the VM in the integration tests #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
force-pushed
the
greenhat/vm-trace-itests
branch
from
149c665 to
28dc6bb
Compare
greenhat
force-pushed
the
greenhat/i225-disable-assert-u32-cast
branch
from
4253aa3 to
6f02803
Compare
bitwalker
reviewed
Jul 10, 2024
tests/integration/src/exec_vm.rs
Outdated
| @@ -1,10 +1,12 @@ | |||
| #![allow(unused)] | |||
Collaborator
There was a problem hiding this comment.
Nit: Is this actually needed? I prefer to only disable warnings module-wide if it is especially noisy and unhelpful; otherwise it's usually easier to just decorate specific items with this attribute instead.
Contributor
Author
There was a problem hiding this comment.
Not really. I agree that decorating a specific item is a better approach.
bitwalker
approved these changes
Jul 10, 2024
greenhat
force-pushed
the
greenhat/vm-trace-itests
branch
from
28dc6bb to
f5e4656
Compare
greenhat
changed the base branch from
greenhat/i225-disable-assert-u32-cast
to
main
greenhat
force-pushed
the
greenhat/vm-trace-itests
branch
from
f5e4656 to
625304e
Compare
greenhat
force-pushed
the
greenhat/vm-trace-itests
branch
from
625304e to
f39e23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #232 and should be merged after it