[7/x] Fix memory cleanup in Emulator::stop
#236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
changed the title
Emulator::stopEmulator::stop
bitwalker
reviewed
Jul 10, 2024
| self.callstack.clear(); | ||
| self.stack.clear(); | ||
| self.memory.clear(); | ||
| self.memory = vec![Self::EMPTY_WORD; self.memory.len()]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.memory = vec![Self::EMPTY_WORD; self.memory.len()]; | |
| self.memory.fill(Self::EMPTY_WORD); |
Contributor
Author
There was a problem hiding this comment.
Good catch! In #237, I reworked it completely (it only cleans "dirty" addresses).
bitwalker
approved these changes
Jul 10, 2024
Collaborator
bitwalker
left a comment
bitwalker
left a comment
There was a problem hiding this comment.
I suggested one minor change, but otherwise looks good - well spotted!
greenhat
force-pushed
the
greenhat/vm-trace-itests
branch
3 times, most recently
from
625304e to
f39e23b
Compare
greenhat
force-pushed
the
greenhat/fix-emu-mem-clean
branch
from
e42373f to
effc46b
Compare
greenhat
force-pushed
the
greenhat/fix-emu-mem-clean
branch
from
effc46b to
8aea8fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on the #233 and should be merged after it