Add plonky3 backend #461
Add plonky3 backend #461
Conversation
adr1anh
left a comment
adr1anh
left a comment
There was a problem hiding this comment.
Had a quick sneak peek, but this is great already! Left two small comments about the codegen.
adr1anh
left a comment
adr1anh
left a comment
There was a problem hiding this comment.
Looks really good! Just left some minor comments which can be addressed in a follow-up PR.
| pub trait AirBuilderWithPeriodicColumns: AirBuilder { | ||
| type PeriodicColumnsVar: Field + Into<Self::Expr>; | ||
|
|
||
| fn periodic_columns(&self) -> Vec<Self::PeriodicColumnsVar> { |
There was a problem hiding this comment.
We should also return a slice here which we can cast to an array.
There was a problem hiding this comment.
I think this is more complicated issue though, since I see below that we're using this to make testing easier.
| { | ||
| type PeriodicColumnsVar = F; | ||
|
|
||
| fn periodic_columns(&self) -> Vec<Self::PeriodicColumnsVar> { |
There was a problem hiding this comment.
While maybe not for this PR, I think we can represent periodic_columns in the DebugConstraintBuilderWithPeriodicColumns struct a bit differently
- Pad all periodic columns to the maximum length by periodic repetition
- Transpose the columns so that we have a vector of rows.
- We just return
&self.periodic_columns[self.row_index % col.len()]
There was a problem hiding this comment.
Hi! I've created an issue to do this in a followup: #492
Al-Kindi-0
left a comment
Al-Kindi-0
left a comment
There was a problem hiding this comment.
Looks great!
Support and testing for periodic columns and buses will come in a follow up PR once we agree on how our version of P3 backend will look like.
Describe your changes
This PR aims to close #450.
It became the tracking branch for Plonky3 Codegen related features.
Tasklist:
AirBuilderWithPeriodicColumnsandBaseAirWithPeriodicColumnsDebugConstraintBuilderWithPeriodicColumnscheck_constraints_with_periodic_columnsto check the constraints are valid for a given traceimplement the traits for upstream structs needed formoved to a followup: feat: prove/verify and sync plonky3 #523proveandverify