-
Notifications
You must be signed in to change notification settings - Fork 36
compare evaluation winterfell plonky3 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Soulthym
wants to merge
50
commits into
0xMiden:next
Choose a base branch
from
massalabs:feat-compare-eval-winterfell-plonky3
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
compare evaluation winterfell plonky3 #533
Soulthym
wants to merge
50
commits into
0xMiden:next
from
massalabs:feat-compare-eval-winterfell-plonky3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d MIR translation
…nly3 and winterfell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Solves #532.
This implements a test harness comparing evaluations on plonky3 and winterfell generated constraints. It compares evaluations on random traces and tailored made ones to account for valid/invalid traces scenarios.
Left as a draft until the task list is marked as completed.
Task list:
Checklist before requesting a review
Repo forked and branch created from
nextaccording to naming convention.This branch is based on the current state of Add plonky3 backend #461
Commit messages and codestyle follow conventions.
Commits are signed.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.
Updated
CHANGELOG.md