[Build Cleanup & Fix] Bump to version 1.0.1#15
Open
DEKHTIARJonathan wants to merge 1 commit into
Open
Conversation
36dc1e0 to
cc21344
Compare
Author
|
@zzyztyy any update ? would be nice to get a fixed released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @zzyztyy thanks for your cool package.
There are a few issues with your packaging system / repo that I fixed
No gitignore
git)build using
setup.pyis deprecated (and you don't need it) and leads to errorIGRF14is not included in your latest releaseI fixed all these problems, added
flitas a build backend to make your life easier.Also added config to
uvif you ever want to switch.As the current package
1.0.0is broken (does not containigrf14coeffs) - I bumped the version to1.0.1so that you can do another proper release ;)Let me know if you have any question - happy to help