fix(graph): preserve and scope duplicate qualified names - #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow legitimate duplicate qualified names without aborting SQLite writes or cross-binding imports to an arbitrary tracked repository.
Qualified names are lookup labels, not global graph identities. Forks, worktrees, manifest overlays, and separate repositories can emit the same value, and Kubernetes resources can also repeat one within a repository across namespaces.
Changes
nodes_by_qualindex with a non-unique partial index through an in-place schema v8 migration.ClusterRole/prometheuswith distinct IDs, ownership, paths, and content.Testing
go test -race ./...) — the repository-wide race suite was not run.Verified:
go test ./internal/graph ./internal/graph/storetest ./internal/graph/store_sqlite ./internal/resolver ./internal/indexer ./internal/parser/languages -count=1go test -race ./internal/graph ./internal/graph/store_sqlitego test -race ./internal/resolvergo build ./internal/graph/... ./internal/resolver/... ./internal/indexer/...git diff --checkChecklist
Meta["methods"]for interfaces (not applicable)EdgeMemberOfedges to their containing type (not applicable)