test(ci): run agent integrations on Windows - #301
Merged
Conversation
Owner
|
@tiendungdev thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestGlobalPointerBody_ShapeAndSentinelassert the OS-native path emitted byfilepath.Joininternal/agentstest package in the existing native Windows CI jobWhy
The Windows job currently compiles production packages but does not execute platform-specific tests. That leaves regressions such as the Windows atomic-write sharing-violation coverage in
internal/agents/writer_windows_test.godependent on local/on-demand verification.Running
go test ./internal/agents -count=1on Windows exposed one portability false-failure before the Windows-only writer tests could be promoted to CI:TestGlobalPointerBody_ShapeAndSentinelhard-coded/active.md, whileGlobalPointerBodyintentionally emits the result offilepath.Join(\active.mdon Windows).This PR fixes that assertion and adds only the package-level test that now has a clean, bounded Windows responsibility.
Verification
go test ./internal/agents -count=1failed atTestGlobalPointerBody_ShapeAndSentinelwith the OS-native@\home\user\.gortex\instructions\active.mdoutputgofmt -w internal/agents/instructions_test.gogit diff --checkwindows-latestCI step is the authoritative post-fix Windows verificationScope
No production behavior changes. No attempt to enable
go test ./...on Windows.