fix(release): gitignore dist-darwin/ so goreleaser sees a clean tree - #186
Merged
Conversation
The release job stages the native-built macOS archives in dist-darwin/
before running `goreleaser release --clean`. goreleaser refuses to run
on a dirty work tree, and the untracked dist-darwin/ tripped it:
git is in a dirty state
?? dist-darwin/
dist/ (goreleaser's own output) was already ignored for the same reason;
dist-darwin/ was missed. Ignore it too so the staged darwin tarballs no
longer make the tree dirty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v0.53.0release job failed (run 28288459792) with:The native-darwin work added in #178 stages the macOS archives in
dist-darwin/(downloaded as an artifact) before runninggoreleaser release --clean. goreleaser refuses to run on a dirty work tree, and the untrackeddist-darwin/tripped that check, so goreleaser aborted before creating the release — nov0.53.0artifacts were published.Fix
dist/(goreleaser's own output) was already in.gitignorefor exactly this reason;dist-darwin/was simply missed. Ignore it too:Verification
With
dist-darwin/populated,git status --porcelain(what goreleaser's dirty check reads) no longer reports it;git status --porcelain --ignoredconfirms the rule matches (!! dist-darwin/). This fixes future releases, matching #178's note about the release path.Follow-up
The
v0.53.0tag produced no release artifacts (goreleaser aborted). After this merges, re-cut the tag (delete + re-pushv0.53.0, or bump tov0.53.1) to actually publish the release.